Merge pull request #1288 from Northeastern-Electric-Racing/#625-node-18-cleanup

#625 Migrate to Node 18

Author: RChandler234

.github/workflows/lint-check.yml

@@ -19,7 +19,7 @@ jobs:
       - name: Set up Node.js
         uses: actions/setup-node@v3
         with:
-          node-version: 16.15.1
+          node-version: 18.17.1
           cache: 'yarn'
       - name: Install modules
         run: yarn install && yarn prisma:generate

.github/workflows/prettier-check.yml

@@ -19,7 +19,7 @@ jobs:
       - name: Set up Node.js
         uses: actions/setup-node@v3
         with:
-          node-version: 16.15.1
+          node-version: 18.17.1
           cache: 'yarn'
       - name: Install modules
         run: yarn install

.github/workflows/run-tests.yml

@@ -23,7 +23,7 @@ jobs:
       - name: Set up Node.js
         uses: actions/setup-node@v3
         with:
-          node-version: 16.15.1
+          node-version: 18.17.1
           cache: 'yarn'
       - name: Install modules
         run: yarn install && yarn prisma:generate

Dockerfile

@@ -1,4 +1,4 @@
-FROM node:16.15.1
+FROM node:18.17.1
 WORKDIR /base
 COPY package.json .
 COPY .yarn .

package.json

@@ -45,7 +45,7 @@
     "@babel/preset-typescript": "^7.18.6",
     "@testing-library/jest-dom": "^5.16.4",
     "@types/jest": "^28.1.6",
-    "@types/node": "^18.11.10",
+    "@types/node": "18.17.1",
     "@types/nodemailer": "^6.4.7",
     "@types/react-query": "^1.2.9",
     "@typescript-eslint/eslint-plugin": "^4.18.0",

src/backend/package.json

@@ -35,7 +35,7 @@
     "@types/express-pino-logger": "4.0.2",
     "@types/jsonwebtoken": "^8.5.9",
     "@types/multer": "^1.4.7",
-    "@types/node": "^14.0.9",
+    "@types/node": "18.17.1",
     "@types/supertest": "^2.0.12",
     "nodemon": "^2.0.16",
     "prisma": "^4.4.0",

src/frontend/package.json

@@ -43,7 +43,7 @@
   "devDependencies": {
     "@testing-library/dom": "^8.19.0",
     "@testing-library/react-hooks": "^8.0.1",
-    "@types/node": "^12.0.0",
+    "@types/node": "18.17.1",
     "@types/react": "^17.0.1",
     "@types/react-dom": "^17.0.1",
     "@types/react-helmet": "^6.1.6",

src/frontend/src/tests/pages/ChangeRequestDetailPage/ReviewChangeRequest.test.tsx

@@ -7,6 +7,7 @@ import { render, screen, routerWrapperBuilder } from '../../test-support/test-ut
 import { routes } from '../../../utils/routes';
 import { exampleStandardChangeRequest } from '../../test-support/test-data/change-requests.stub';
 import ReviewChangeRequest from '../../../pages/ChangeRequestDetailPage/ReviewChangeRequest';
+import { ChangeRequestStatus } from 'shared';
 
 const renderComponent = (modalShow: boolean, route: string) => {
   const RouterWrapper = routerWrapperBuilder({ path: routes.CHANGE_REQUESTS_BY_ID, route });
@@ -31,7 +32,10 @@ const renderComponent = (modalShow: boolean, route: string) => {
             workPackageNumber: 0
           },
           dateSubmitted: new Date(),
-          type: 'ISSUE'
+          type: 'ISSUE',
+          wbsName: 'a',
+          status: ChangeRequestStatus.Open,
+          requestedReviewers: []
         }}
         modalShow={modalShow}
         handleClose={() => null}

src/shared/package.json

@@ -11,7 +11,7 @@
   "author": "",
   "license": "ISC",
   "devDependencies": {
-    "@types/node": "^14.0.9",
+    "@types/node": "18.17.1",
     "ts-node": "^8.10.1",
     "typescript": "^4.1.5"
   }

yarn.lock

@@ -3806,24 +3806,10 @@ __metadata:
   languageName: node
   linkType: hard
 
-"@types/node@npm:^12.0.0":
-  version: 12.20.55
-  resolution: "@types/node@npm:12.20.55"
-  checksum: e4f86785f4092706e0d3b0edff8dca5a13b45627e4b36700acd8dfe6ad53db71928c8dee914d4276c7fd3b6ccd829aa919811c9eb708a2c8e4c6eb3701178c37
-  languageName: node
-  linkType: hard
-
-"@types/node@npm:^14.0.9":
-  version: 14.18.53
-  resolution: "@types/node@npm:14.18.53"
-  checksum: 3acbcf4e38cdc5999c824db5c6689ca8f4a185562aad5c0263d9859381d8590a16e6a72343aeb30d48ff9a7ac9b6ae259bcb8c2d594703a30d12277904524704
-  languageName: node
-  linkType: hard
-
-"@types/node@npm:^18.11.10":
-  version: 18.16.19
-  resolution: "@types/node@npm:18.16.19"
-  checksum: 63c31f09616508aa7135380a4c79470a897b75f9ff3a70eb069e534dfabdec3f32fb0f9df5939127f1086614d980ddea0fa5e8cc29a49103c4f74cd687618aaf
+"@types/node@npm:18.17.1":
+  version: 18.17.1
+  resolution: "@types/node@npm:18.17.1"
+  checksum: 56201bda9a2d05d68602df63b4e67b0545ac8c6d0280bd5fb31701350a978a577a027501fbf49db99bf177f2242ebd1244896bfd35e89042d5bd7dfebff28d4e
   languageName: node
   linkType: hard
 
@@ -5543,7 +5529,7 @@ __metadata:
     "@types/express-pino-logger": 4.0.2
     "@types/jsonwebtoken": ^8.5.9
     "@types/multer": ^1.4.7
-    "@types/node": ^14.0.9
+    "@types/node": 18.17.1
     "@types/supertest": ^2.0.12
     body-parser: ^1.19.0
     concat-stream: ^2.0.0
@@ -9644,7 +9630,7 @@ __metadata:
     "@babel/preset-typescript": ^7.18.6
     "@testing-library/jest-dom": ^5.16.4
     "@types/jest": ^28.1.6
-    "@types/node": ^18.11.10
+    "@types/node": 18.17.1
     "@types/nodemailer": ^6.4.7
     "@types/react-query": ^1.2.9
     "@typescript-eslint/eslint-plugin": ^4.18.0
@@ -9841,7 +9827,7 @@ __metadata:
     "@testing-library/react-hooks": ^8.0.1
     "@testing-library/user-event": ^12.6.3
     "@types/file-saver": ^2.0.5
-    "@types/node": ^12.0.0
+    "@types/node": 18.17.1
     "@types/react": ^17.0.1
     "@types/react-dom": ^17.0.1
     "@types/react-helmet": ^6.1.6
@@ -17771,7 +17757,7 @@ __metadata:
   version: 0.0.0-use.local
   resolution: "shared@workspace:src/shared"
   dependencies:
-    "@types/node": ^14.0.9
+    "@types/node": 18.17.1
     ts-node: ^8.10.1
     typescript: ^4.1.5
   languageName: unknown