#1644: proposed solutions redesign

Author: mattrwang

src/frontend/src/pages/ChangeRequestDetailPage/ProposedSolutionView.tsx

@@ -60,7 +60,7 @@ const ProposedSolutionView: React.FC<ProposedSolutionViewProps> = ({
             <Typography>{weeksPipe(proposedSolution.timelineImpact)}</Typography>
           </Grid>
           <Grid item>{proposedSolution.approved && <Chip label="Approved" color="success" />}</Grid>
-          {showDeleteButton && onDelete !== undefined ? (
+          {showDeleteButton && onDelete !== undefined && (
             <Grid item>
               <Button
                 color="error"
@@ -72,7 +72,7 @@ const ProposedSolutionView: React.FC<ProposedSolutionViewProps> = ({
                 <DeleteIcon />
               </Button>
             </Grid>
-          ) : null}
+          )}
         </Grid>
       </Grid>
     </Grid>

src/frontend/src/pages/CreateChangeRequestPage/CreateChangeRequestView.tsx

@@ -199,17 +199,17 @@ const CreateChangeRequestsView: React.FC<CreateChangeRequestViewProps> = ({
         previousPages={[{ name: 'Change Requests', route: routes.CHANGE_REQUESTS }]}
         headerRight={
           <Box textAlign="right" sx={{ mb: 2 }}>
-            <NERFailButton variant="contained" onClick={handleCancel} sx={{ mx: 1 }}>
+            <NERFailButton variant="contained" onClick={handleCancel} sx={{ mx: 1, width: 90 }}>
               Cancel
             </NERFailButton>
-            <NERSuccessButton variant="contained" type="submit" sx={{ mx: 1 }}>
+            <NERSuccessButton variant="contained" type="submit" sx={{ mx: 1, width: 90, mt: { xs: 1, md: 0 } }}>
               Submit
             </NERSuccessButton>
           </Box>
         }
       >
         <Grid container spacing={2} display="flex" justifyContent="space-between">
-          <Grid container item spacing={2} xs={5} maxHeight={0} sx={{ mt: -5 }}>
+          <Grid container item spacing={2} xs={12} md={6}>
             <Grid item xs={12}>
               <FormLabel>WBS</FormLabel>
               <NERAutocomplete
@@ -308,8 +308,7 @@ const CreateChangeRequestsView: React.FC<CreateChangeRequestViewProps> = ({
               </Button>
             </Grid>
           </Grid>
-          <Grid item xs={1} />
-          <Grid item xs={5} sx={{ mt: -2 }}>
+          <Grid item xs={12} md={5} sx={{ mt: -2 }}>
             <CreateProposedSolutionsList proposedSolutions={proposedSolutions} setProposedSolutions={setProposedSolutions} />
           </Grid>
         </Grid>

src/frontend/src/pages/CreateChangeRequestPage/CreateProposedSolutionsList.tsx

@@ -23,8 +23,6 @@ const CreateProposedSolutionsList: React.FC<CreateProposedSolutionsListProps> =
   const user = useCurrentUser();
   const [showEditableForm, setShowEditableForm] = useState<boolean>(false);
 
-  if (!user) return <LoadingIndicator />;
-
   const addProposedSolution = async (data: ProposedSolution) => {
     setProposedSolutions([...proposedSolutions, data]);
     setShowEditableForm(false);