#1523 : Fixed final review

Author: martin0he

src/backend/src/controllers/projects.controllers.ts

@@ -196,7 +196,7 @@ export default class ProjectsController {
   static async deleteManufacturer(req: Request, res: Response, next: NextFunction) {
     try {
       const user: User = await getCurrentUser(res);
-      const { manufacturerName } = req.body;
+      const { manufacturerName } = req.params;
       const deletedManufacturer: Manufacturer = await ProjectsService.deleteManufacturer(user, manufacturerName);
       res.status(200).json(deletedManufacturer);
     } catch (error: unknown) {

src/backend/src/prisma/schema.prisma

@@ -114,7 +114,7 @@ model User {
   createdAssemblies         Assembly[]              @relation(name: "assemblyCreator")
   deletedMaterials          Material[]              @relation(name: "materialDeleter")
   createdMaterials          Material[]              @relation(name: "materialCreator")
-  deletedManufacturers       Manufacturer[]          @relation(name: "deletedManufacturer")
+  deletedManufacturers      Manufacturer[]          @relation(name: "deletedManufacturer")
 }
 
 model Team {

src/backend/src/services/projects.services.ts

@@ -798,11 +798,10 @@ export default class ProjectsService {
    * Deletes a manufacturer
    * @param user the user who's deleting the manufacturer
    * @param name the name of the manufacturer
-   * @throws if the user is not at least a head (includes admin), or if the provided name isn't a manufacturer
+   * @throws if the user is not at least a head, or if the provided name isn't a manufacturer, or if the manufacturer has already been soft-deleted
    * @returns the deleted manufacturer
    */
   static async deleteManufacturer(user: User, name: string) {
-    console.log('e');
     if (!isHead(user.role)) {
       throw new AccessDeniedException('Only heads and above can delete a manufacturer');
     }