#2228 - fix hook

Author: RChandler234

src/backend/src/services/design-reviews.services.ts

@@ -158,7 +158,6 @@ export default class DesignReviewsService {
       throw new NotFoundException('User Settings', 'Cannot find settings of members');
     }
 
-    console.log(memberUserSettings);
     // send a slack message to all leadership invited to the design review
     for (const memberUserSetting of memberUserSettings) {
       if (memberUserSetting.slackId) {
@@ -355,7 +354,7 @@ export default class DesignReviewsService {
 
       // If all requested attendees have confirmed their schedule, mark design review as confirmed
       if (
-        designReview.confirmedMembers.length ===
+        updatedDesignReview.confirmedMembers.length ===
         designReview.requiredMembers.length + designReview.optionalMembers.length
       ) {
         await prisma.design_Review.update({

src/frontend/src/hooks/design-reviews.hooks.ts

@@ -103,11 +103,15 @@ export const useAllTeamTypes = () => {
  *
  * @returns a single design review
  */
-export const useSingleDesignReview = (id: string) => {
-  return useQuery<DesignReview, Error>(['design-reviews', id], async () => {
-    const { data } = await getSingleDesignReview(id);
-    return data;
-  });
+export const useSingleDesignReview = (id?: string) => {
+  return useQuery<DesignReview, Error>(
+    ['design-reviews', id],
+    async () => {
+      const { data } = await getSingleDesignReview(id!);
+      return data;
+    },
+    { enabled: !!id }
+  );
 };
 
 export const useMarkUserConfirmed = (id: string) => {

src/frontend/src/pages/SettingsPage/UserScheduleSettings/UserScheduleSettings.tsx

@@ -46,7 +46,7 @@ const UserScheduleSettings = ({ user }: { user: User }) => {
     isError: designReviewIsError,
     error: designReviewError,
     isLoading: designReviewIsLoading
-  } = useSingleDesignReview(designReviewId || '');
+  } = useSingleDesignReview(designReviewId ?? undefined);
 
   if (designReviewId && (!designReview || designReviewIsLoading)) return <LoadingIndicator />;
   if (!data || isLoading || updateUserScheduleSettingsIsLoading) return <LoadingIndicator />;

src/frontend/src/pages/SettingsPage/UserScheduleSettings/UserScheduleSettingsView.tsx

@@ -28,9 +28,11 @@ const UserScheduleSettingsView = ({
   const [confirmAvailabilityOpen, setConfirmAvailabilityOpen] = useState(defaultOpen || false);
   const [confirmedAvailabilities, setConfirmedAvailabilities] = useState(scheduleSettings.availability);
   const { mutateAsync } = useMarkUserConfirmed(designReview?.designReviewId || '');
-  const confirmModalTitle = `Update your availability for the ${
-    designReview?.wbsName
-  } Design Review on the week of ${designReview?.dateScheduled.toLocaleDateString()}`;
+  const confirmModalTitle = designReview
+    ? `Update your availability for the ${
+        designReview?.wbsName
+      } Design Review on the week of ${designReview?.dateScheduled.toLocaleDateString()}`
+    : '';
 
   const handleConfirm = async (payload: { availability: number[] }) => {
     setConfirmAvailabilityOpen(false);