optimized checking wp lead, fixd error message and tests

Author: msereeyothin

.vscode/settings.json

@@ -21,8 +21,5 @@
     "editor.defaultFormatter": "Prisma.prisma"
   },
   "editor.formatOnSave": true,
-  "typescript.tsdk": "node_modules/typescript/lib",
-  "githubPullRequests.ignoredPullRequestBranches": [
-    "develop"
-  ]
+  "typescript.tsdk": "node_modules/typescript/lib"
 }

src/backend/src/services/tasks.services.ts

@@ -55,20 +55,20 @@ export default class TasksService {
     const isProjectLeadOrManager =
       createdBy.userId === requestedWbsElement.projectLeadId || createdBy.userId === requestedWbsElement.projectManagerId;
 
-    const curWorkPackages = requestedWbsElement.project?.workPackages;
+    const curWorkPackages = project.workPackages;
 
-    const isWorkPackageLead = curWorkPackages?.some((workPackage) => {
+    const isWorkPackageLead = curWorkPackages.some((workPackage) => {
       return workPackage.wbsElement.projectLeadId === createdBy.userId;
     });
 
     if (
       !isLeadership(createdBy.role) &&
       !isProjectLeadOrManager &&
-      isWorkPackageLead &&
+      !isWorkPackageLead &&
       !teams.some((team) => isUserOnTeam(team, createdBy))
     ) {
       throw new AccessDeniedException(
-        'Only admins, app-admins, project leads, project managers, or current team users can create tasks'
+        'Only admins, app-admins, project leads, project managers, work package leads, or current team users can create tasks'
       );
     }
 

src/backend/tests/tasks.test.ts

@@ -63,7 +63,7 @@ describe('Tasks', () => {
         TasksService.createTask(theVisitor, mockWBSNum, 'hellow world', '', mockDate, 'HIGH', 'DONE', [])
       ).rejects.toThrow(
         new AccessDeniedException(
-          'Only admins, app-admins, project leads, project managers, or current team users can create tasks'
+          'Only admins, app-admins, project leads, project managers, work package leads, or current team users can create tasks'
         )
       );