Skip to content

Commit 9a22f45

Browse files
committed
#1658 changed name and added comments
1 parent 4d94f1a commit 9a22f45

2 files changed

Lines changed: 8 additions & 3 deletions

File tree

src/backend/src/services/reimbursement-requests.services.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ import {
2424
removeDeletedReceiptPictures,
2525
updateReimbursementProducts,
2626
validateReimbursementProducts,
27-
validateUserEditReimbursementRequest,
27+
validateUserEditRRPermissions,
2828
validateUserIsPartOfFinanceTeam
2929
} from '../utils/reimbursement-requests.utils';
3030
import {
@@ -256,7 +256,7 @@ export default class ReimbursementRequestService {
256256

257257
if (!oldReimbursementRequest) throw new NotFoundException('Reimbursement Request', requestId);
258258
if (oldReimbursementRequest.dateDeleted) throw new DeletedException('Reimbursement Request', requestId);
259-
await validateUserEditReimbursementRequest(submitter, oldReimbursementRequest);
259+
await validateUserEditRRPermissions(submitter, oldReimbursementRequest);
260260

261261
const vendor = await prisma.vendor.findUnique({
262262
where: { vendorId }

src/backend/src/utils/reimbursement-requests.utils.ts

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -234,7 +234,12 @@ const isTeamIdInList = (teamId: string, teamsList: Team[]) => {
234234
return teamsList.map((team) => team.teamId).includes(teamId);
235235
};
236236

237-
export const validateUserEditReimbursementRequest = async (user: User, reimbursementRequest: Reimbursement_Request) => {
237+
/**
238+
* Validates user has permission to edit the reimbursement request.
239+
* @param user the person editing the reimbursement request
240+
* @param reimbursementRequest the reimbursement request to edit
241+
*/
242+
export const validateUserEditRRPermissions = async (user: User, reimbursementRequest: Reimbursement_Request) => {
238243
try {
239244
await validateUserIsPartOfFinanceTeam(user);
240245
} catch {

0 commit comments

Comments
 (0)