Skip to content

Commit 9a6c27e

Browse files
committed
#1521: Changed some test and error messages
1 parent 1f5b865 commit 9a6c27e

2 files changed

Lines changed: 5 additions & 5 deletions

File tree

src/backend/src/services/projects.services.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -612,7 +612,7 @@ export default class ProjectsService {
612612
}
613613
});
614614

615-
if (manufacturer) throw new HttpException(400, `The following manufacturer already exists: ${name}`);
615+
if (manufacturer) throw new HttpException(400, `${name} already exists as a manufacturer!`);
616616

617617
const newManufacturer = await prisma.manufacturer.create({
618618
data: { name, dateCreated: new Date(), creatorId: submitter.userId }

src/backend/tests/projects.test.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -255,21 +255,21 @@ describe('Projects', () => {
255255
});
256256

257257
describe('Manufacturer Tests', () => {
258-
test('Create Manufacturer throws an error if user is guest', async () => {
258+
test('createManufacturer throws an error if user is a guest', async () => {
259259
await expect(ProjectsService.createManufacturer(wonderwoman, 'NAME')).rejects.toThrow(
260260
new AccessDeniedGuestException('create manufacturers')
261261
);
262262
});
263263

264-
test('Create Manufacturer throws an error if manufacturer already exists', async () => {
264+
test('createManufacturer throws an error if manufacturer already exists', async () => {
265265
vi.spyOn(prisma.manufacturer, 'create').mockResolvedValue(prismaManufacturer1);
266266

267267
await expect(ProjectsService.createManufacturer(batman, 'Manufacturer1')).rejects.toThrow(
268-
new HttpException(400, 'The following manufacturer already exists: Manufacturer1')
268+
new HttpException(400, 'Manufacturer1 already exists as a manufacturer!')
269269
);
270270
});
271271

272-
test('Create Manufacturer successfully returns correct Name and Creator ID', async () => {
272+
test('createManufacturer works as intended and successfully returns correct name and creator ID', async () => {
273273
vi.spyOn(prisma.manufacturer, 'findUnique').mockResolvedValue(null);
274274
vi.spyOn(prisma.manufacturer, 'create').mockResolvedValue(prismaManufacturer1);
275275

0 commit comments

Comments
 (0)