Skip to content

Commit a35762a

Browse files
committed
#2238 - only attendance for done design reviews counts
1 parent a5b34b7 commit a35762a

1 file changed

Lines changed: 17 additions & 14 deletions

File tree

src/frontend/src/pages/AdminToolsPage/AdminToolsAttendeeDesignReviewInfo.tsx

Lines changed: 17 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@ import ErrorPage from '../ErrorPage';
77
import { fullNamePipe } from '../../utils/pipes';
88
import { useAllUsers } from '../../hooks/users.hooks';
99
import { useAllDesignReviews } from '../../hooks/design-reviews.hooks';
10+
import { DesignReviewStatus } from 'shared';
1011

1112
const AdminToolsAttendeeDesignReviewInfo: React.FC = () => {
1213
const [searchQuery, setSearchQuery] = useState('');
@@ -38,22 +39,24 @@ const AdminToolsAttendeeDesignReviewInfo: React.FC = () => {
3839
const missedDict: Map<number, number> = new Map();
3940

4041
allDesignReviews.forEach((review) => {
41-
review.attendees.forEach((member) => {
42-
if (attendanceDict.has(member.userId)) {
43-
attendanceDict.set(member.userId, attendanceDict.get(member.userId)! + 1);
44-
} else {
45-
attendanceDict.set(member.userId, 1);
46-
}
47-
});
48-
review.requiredMembers.forEach((member) => {
49-
if (!review.attendees.map((user) => user.userId).includes(member.userId)) {
50-
if (missedDict.has(member.userId)) {
51-
missedDict.set(member.userId, missedDict.get(member.userId)! + 1);
42+
if (review.status === DesignReviewStatus.DONE) {
43+
review.attendees.forEach((member) => {
44+
if (attendanceDict.has(member.userId)) {
45+
attendanceDict.set(member.userId, attendanceDict.get(member.userId)! + 1);
5246
} else {
53-
missedDict.set(member.userId, 1);
47+
attendanceDict.set(member.userId, 1);
5448
}
55-
}
56-
});
49+
});
50+
review.requiredMembers.forEach((member) => {
51+
if (!review.attendees.map((user) => user.userId).includes(member.userId)) {
52+
if (missedDict.has(member.userId)) {
53+
missedDict.set(member.userId, missedDict.get(member.userId)! + 1);
54+
} else {
55+
missedDict.set(member.userId, 1);
56+
}
57+
}
58+
});
59+
}
5760
});
5861

5962
const attendeeRows = filteredMembers.map((member, index) => (

0 commit comments

Comments
 (0)