Skip to content

Commit ab27379

Browse files
committed
#1642: new pop up tab
1 parent 7eb6358 commit ab27379

2 files changed

Lines changed: 11 additions & 5 deletions

File tree

src/frontend/src/pages/ChangeRequestDetailPage/ChangeRequestDetailsView.tsx

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -153,7 +153,9 @@ const ChangeRequestDetailsView: React.FC<ChangeRequestDetailsProps> = ({
153153
{deleteModalShow && (
154154
<DeleteChangeRequest modalShow={deleteModalShow} handleClose={handleDeleteClose} cr={changeRequest} />
155155
)}
156-
<OtherChangeRequestsPopupTabs changeRequest={changeRequest} />
156+
<Grid container spacing={1} style={{ display: 'flex'}}>
157+
<OtherChangeRequestsPopupTabs changeRequest={changeRequest} fromSubmitter={true} />
158+
</Grid>
157159
</PageLayout>
158160
);
159161
};

src/frontend/src/pages/ChangeRequestDetailPage/OtherChangeRequestsPopupTabs.tsx

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55

66
import React, { useState } from 'react';
77
import { Box, useTheme, Collapse, Tabs, Tab, Typography } from '@mui/material';
8-
import { ChangeRequest } from 'shared';
8+
import { ChangeRequest, wbsPipe } from 'shared';
99
import ChangeRequestDetailCard from '../../components/ChangeRequestDetailCard';
1010
import { useAllChangeRequests } from '../../hooks/change-requests.hooks';
1111
import { ExpandLess, ExpandMore } from '@mui/icons-material';
@@ -15,10 +15,11 @@ import { fullNamePipe } from '../../utils/pipes';
1515

1616
interface OtherChangeRequestsPopupTabsProps {
1717
changeRequest: ChangeRequest;
18+
fromSubmitter: boolean;
1819
}
1920

2021
const OtherChangeRequestsPopupTabs: React.FC<OtherChangeRequestsPopupTabsProps> = ({
21-
changeRequest
22+
changeRequest, fromSubmitter
2223
}: OtherChangeRequestsPopupTabsProps) => {
2324
const theme = useTheme();
2425
const [tab, setTab] = useState(0);
@@ -38,6 +39,8 @@ const OtherChangeRequestsPopupTabs: React.FC<OtherChangeRequestsPopupTabsProps>
3839
return b.dateSubmitted.getTime() - a.dateSubmitted.getTime();
3940
});
4041

42+
const crsFromWbs = changeRequests?.filter((cr) => (cr.wbsNum) === changeRequest.wbsNum);
43+
4144
const displayTab = (value: number, title: string) => (
4245
<Tab
4346
value={value}
@@ -113,9 +116,10 @@ const OtherChangeRequestsPopupTabs: React.FC<OtherChangeRequestsPopupTabsProps>
113116
mb: '-1px'
114117
}}
115118
>
116-
{displayTab(1, `Other CR's from ${fullNamePipe(changeRequest.submitter)}`)}
119+
{displayTab(1, `Other CR's from ${wbsPipe(changeRequest.wbsNum)}`)}
120+
{displayTab(2, `Other CR's from ${fullNamePipe(changeRequest.submitter)}`)}
117121
</Tabs>
118-
<Collapse in={tab !== 0}>{tab === 1 && displayCRCards(crsFromSubmitter || [])}</Collapse>
122+
<Collapse in={tab !== 0}>{tab === 1 ? displayCRCards((crsFromWbs) || []) : (tab === 2 && displayCRCards((crsFromSubmitter) || []))}</Collapse>
119123
</Box>
120124
);
121125
};

0 commit comments

Comments
 (0)