#1250: Fixed bad try/catches

Author: sharonyang16

src/frontend/src/hooks/auth.hooks.ts

@@ -27,13 +27,9 @@ export const useProvideAuth = () => {
   };
 
   const signin = async (id_token: string) => {
-    try {
-      const user = await mutateAsync(id_token);
-      setUser(user);
-      return user;
-    } catch (e) {
-      // do nothing; toasting error message will cause errors
-    }
+    const user = await mutateAsync(id_token);
+    setUser(user);
+    return user;
   };
 
   const signout = () => {

src/frontend/src/pages/CreateChangeRequestPage/CreateChangeRequest.tsx

@@ -53,28 +53,23 @@ const CreateChangeRequest: React.FC<CreateChangeRequestProps> = () => {
       const crId = parseInt(cr.message);
       proposedSolutions.forEach(async (ps) => {
         const { description, timelineImpact, scopeImpact, budgetImpact } = ps;
-        try {
-          await cpsMutateAsync({
-            crId,
-            submitterId: userId,
-            description,
-            timelineImpact,
-            scopeImpact,
-            budgetImpact
-          });
-        } catch (error: unknown) {
-          if (error instanceof Error) {
-            toast.error(error.message);
-          }
-        }
+
+        await cpsMutateAsync({
+          crId,
+          submitterId: userId,
+          description,
+          timelineImpact,
+          scopeImpact,
+          budgetImpact
+        });
       });
+
+      history.push(routes.CHANGE_REQUESTS);
     } catch (e) {
       if (e instanceof Error) {
         toast.error(e.message);
       }
     }
-
-    history.push(routes.CHANGE_REQUESTS);
   };
 
   const handleCancel = () => {

src/frontend/src/pages/FinancePage/CreateReimbursementRequest.tsx

@@ -20,19 +20,12 @@ const CreateReimbursementRequestPage: React.FC = () => {
   if (createReimbursementRequestIsLoading || receiptsIsLoading) return <LoadingIndicator />;
 
   const onSubmit = async (data: ReimbursementRequestDataSubmission): Promise<string> => {
-    try {
-      const { reimbursementRequestId } = await createReimbursementRequest(data);
-      await uploadReceipts({
-        id: reimbursementRequestId,
-        files: data.receiptFiles.map((file) => file.file!)
-      });
-      return reimbursementRequestId;
-    } catch (e) {
-      if (e instanceof Error) {
-        toast.error(e.message);
-      }
-    }
-    throw new Error('Could not create reimbursement.');
+    const { reimbursementRequestId } = await createReimbursementRequest(data);
+    await uploadReceipts({
+      id: reimbursementRequestId,
+      files: data.receiptFiles.map((file) => file.file!)
+    });
+    return reimbursementRequestId;
   };
 
   return (

src/frontend/src/pages/FinancePage/EditReimbursementRequest/EditReimbursementRequest.tsx

@@ -31,17 +31,11 @@ const EditReimbursementRequestPage: React.FC = () => {
   const onSubmit = async (data: ReimbursementRequestDataSubmission): Promise<string> => {
     const filesToKeep = data.receiptFiles.filter((file) => file.googleFileId !== '');
 
-    try {
-      await editReimbursementRequest({ ...data, receiptPictures: filesToKeep });
-      await uploadReceipts({
-        id: reimbursementRequest.reimbursementRequestId,
-        files: data.receiptFiles.filter((receipt) => receipt.googleFileId === '').map((file) => file.file!)
-      });
-    } catch (e) {
-      if (e instanceof Error) {
-        toast.error(e.message);
-      }
-    }
+    await editReimbursementRequest({ ...data, receiptPictures: filesToKeep });
+    await uploadReceipts({
+      id: reimbursementRequest.reimbursementRequestId,
+      files: data.receiptFiles.filter((receipt) => receipt.googleFileId === '').map((file) => file.file!)
+    });
 
     return reimbursementRequest.reimbursementRequestId;
   };