Skip to content

Commit e3ebe9e

Browse files
authored
Merge pull request #2235 from Northeastern-Electric-Racing/#2140-rm-page-blocks-user-management
#2140 rm page blocks from user management
2 parents b882ffc + 9675142 commit e3ebe9e

3 files changed

Lines changed: 31 additions & 29 deletions

File tree

src/frontend/src/pages/AdminToolsPage/AdminToolsPage.tsx

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ import AdminToolsProjectsConfig from './AdminToolsProjectsConfig';
1616
import { useState } from 'react';
1717
import NERTabs from '../../components/Tabs';
1818
import { routes } from '../../utils/routes';
19-
import { Box } from '@mui/material';
19+
import { Box } from '@mui/system';
2020

2121
const AdminToolsPage: React.FC = () => {
2222
const currentUser = useCurrentUser();
@@ -43,10 +43,12 @@ const AdminToolsPage: React.FC = () => {
4343

4444
const UserManagementTab = () => {
4545
return isUserAdmin ? (
46-
<>
47-
<AdminToolsUserManagement />
46+
<Box>
47+
<Box mb={2}>
48+
<AdminToolsUserManagement />
49+
</Box>
4850
<TeamsTools />
49-
</>
51+
</Box>
5052
) : (
5153
<AdminToolsUserManagement />
5254
);

src/frontend/src/pages/AdminToolsPage/AdminToolsUserManagement.tsx

Lines changed: 19 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,7 @@
44
*/
55

66
import { NERButton } from '../../components/NERButton';
7-
import { Grid, Typography, useTheme } from '@mui/material';
8-
import PageBlock from '../../layouts/PageBlock';
7+
import { Box, Grid, Typography, useTheme } from '@mui/material';
98
import Select, { SelectChangeEvent } from '@mui/material/Select';
109
import MenuItem from '@mui/material/MenuItem';
1110
import { useState } from 'react';
@@ -21,7 +20,6 @@ const AdminToolsUserManagement: React.FC = () => {
2120
const [role, setRole] = useState('');
2221
const [user, setUser] = useState<User | null>(null);
2322
const [isDisabled, setIsDisabled] = useState(true);
24-
const [hideSuccessLabel, setHideSuccessLabel] = useState(true);
2523
const { isLoading, isError, error, data: users } = useAllUsers();
2624
const updateUserRole = useUpdateUserRole();
2725
const theme = useTheme();
@@ -52,7 +50,6 @@ const AdminToolsUserManagement: React.FC = () => {
5250
if (user) {
5351
setUser(user);
5452
setRole(user.role);
55-
setHideSuccessLabel(true);
5653
}
5754
} else {
5855
setUser(null);
@@ -69,11 +66,10 @@ const AdminToolsUserManagement: React.FC = () => {
6966
};
7067

7168
const handleClick = async () => {
72-
setHideSuccessLabel(true);
7369
if (!user) return;
7470
try {
7571
await updateUserRole.mutateAsync({ userId: user.userId, role });
76-
setHideSuccessLabel(false);
72+
toast.success('Role updated successfully!');
7773
setUser(null);
7874
} catch (e) {
7975
if (e instanceof Error) {
@@ -87,9 +83,12 @@ const AdminToolsUserManagement: React.FC = () => {
8783
};
8884

8985
return (
90-
<PageBlock title={'Role Management'}>
86+
<Box>
87+
<Typography variant="h5" gutterBottom borderBottom={1} color="red" borderColor={'white'} marginBottom={'20px'}>
88+
Role Management
89+
</Typography>
9190
<Grid container spacing={2}>
92-
<Grid item xs={12} md={8}>
91+
<Grid item xs={12} md={7}>
9392
<NERAutocomplete
9493
id="users-autocomplete"
9594
onChange={usersSearchOnChange}
@@ -99,7 +98,7 @@ const AdminToolsUserManagement: React.FC = () => {
9998
value={user ? userToAutocompleteOptionWithRole(user) : null}
10099
/>
101100
</Grid>
102-
<Grid item xs={12} md={4}>
101+
<Grid item xs={12} md={3} mt={1}>
103102
<Select
104103
displayEmpty={true}
105104
renderValue={(value) => (value ? value : user ? user.role : 'Current Role')}
@@ -126,19 +125,18 @@ const AdminToolsUserManagement: React.FC = () => {
126125
))}
127126
</Select>
128127
</Grid>
128+
<Grid item xs={12} md={'auto'} mt={-1.5}>
129+
<NERButton
130+
sx={{ mt: '20px', float: 'right' }}
131+
variant="contained"
132+
disabled={isDisabled || !user}
133+
onClick={handleClick}
134+
>
135+
Confirm
136+
</NERButton>
137+
</Grid>
129138
</Grid>
130-
<NERButton
131-
sx={{ mt: '20px', float: 'right' }}
132-
variant="contained"
133-
disabled={isDisabled || !user}
134-
onClick={handleClick}
135-
>
136-
Confirm
137-
</NERButton>
138-
<Typography hidden={hideSuccessLabel} style={{ color: theme.palette.primary.main, marginTop: '20px' }}>
139-
Successfully Updated User
140-
</Typography>
141-
</PageBlock>
139+
</Box>
142140
);
143141
};
144142

src/frontend/src/pages/AdminToolsPage/TeamsTools.tsx

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
1-
import { Box, FormControl, FormLabel, Grid, TableCell, TableRow } from '@mui/material';
1+
import { Box, FormControl, FormLabel, Grid, TableCell, TableRow, Typography } from '@mui/material';
22
import { routes } from '../../utils/routes';
33
import { Link as RouterLink } from 'react-router-dom';
4-
import PageBlock from '../../layouts/PageBlock';
54
import { NERButton } from '../../components/NERButton';
65
import { useAllTeams, useCreateTeam } from '../../hooks/teams.hooks';
76
import LoadingIndicator from '../../components/LoadingIndicator';
@@ -90,7 +89,10 @@ const TeamsTools = () => {
9089
));
9190

9291
return (
93-
<PageBlock title="Team Management">
92+
<Box>
93+
<Typography variant="h5" gutterBottom borderBottom={1} color="red" borderColor={'white'}>
94+
Team Management
95+
</Typography>
9496
<Grid container columnSpacing={2}>
9597
<Grid item xs={12} md={6}>
9698
<form
@@ -154,7 +156,7 @@ const TeamsTools = () => {
154156
/>
155157
</Grid>
156158
</Grid>
157-
</PageBlock>
159+
</Box>
158160
);
159161
};
160162

0 commit comments

Comments
 (0)