Skip to content

Commit eab0d4f

Browse files
committed
#1658 changed error message
1 parent 8c42cc8 commit eab0d4f

2 files changed

Lines changed: 3 additions & 13 deletions

File tree

src/backend/src/services/reimbursement-requests.services.ts

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -259,9 +259,7 @@ export default class ReimbursementRequestService {
259259
await validateUserIsPartOfFinanceTeam(submitter);
260260
} catch {
261261
if (oldReimbursementRequest.recipientId !== submitter.userId)
262-
throw new AccessDeniedException(
263-
'You do not have access to edit this reimbursement request, only the creator or finance team can edit a reimbursement request'
264-
);
262+
throw new AccessDeniedException('Only the creator or finance team can edit a reimbursement request');
265263
}
266264

267265
const vendor = await prisma.vendor.findUnique({

src/backend/tests/reimbursement-requests.test.ts

Lines changed: 2 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -222,11 +222,7 @@ describe('Reimbursement Requests', () => {
222222
[],
223223
superman
224224
)
225-
).rejects.toThrow(
226-
new AccessDeniedException(
227-
'You do not have access to edit this reimbursement request, only the creator or finance team can edit a reimbursement request'
228-
)
229-
);
225+
).rejects.toThrow(new AccessDeniedException('Only the creator or finance team can edit a reimbursement request'));
230226
});
231227

232228
test('Edit Reimbursement Request fails if Submitter not on Finance Team', async () => {
@@ -243,11 +239,7 @@ describe('Reimbursement Requests', () => {
243239
[],
244240
alfred
245241
)
246-
).rejects.toThrow(
247-
new AccessDeniedException(
248-
'You do not have access to edit this reimbursement request, only the creator or finance team can edit a reimbursement request'
249-
)
250-
);
242+
).rejects.toThrow(new AccessDeniedException('Only the creator or finance team can edit a reimbursement request'));
251243
});
252244

253245
test('Edit Reimbursement Request Fails When Vendor does not exist', async () => {

0 commit comments

Comments
 (0)