Merge pull request #2021 from Northeastern-Electric-Racing/#1661-add-auto-incrementing-int-in-RR

#1661: added auto-incrementing identifier in RR

Author: walker-sean

src/backend/src/prisma/migrations/20240129020615_rr_identifier/migration.sql

@@ -0,0 +1,32 @@
+/*
+  Warnings:
+
+  - A unique constraint covering the columns `[identifier]` on the table `Reimbursement_Request` will be added. If there are existing duplicate values, this will fail.
+
+*/
+-- Select all old RRs that has no identifier in dateCreated ascending order
+CREATE TEMP TABLE cte_table AS (
+    WITH CTE AS (
+        SELECT 
+            "reimbursementRequestId",
+            row_number() OVER (ORDER BY "dateCreated" ASC, "reimbursementRequestId" ASC) AS new_identifier
+        FROM 
+            "Reimbursement_Request"
+    )
+    SELECT * FROM CTE
+);
+
+-- AlterTable
+ALTER TABLE "Reimbursement_Request" ADD COLUMN     "identifier" SERIAL NOT NULL;
+
+-- Assign Identifier to all old Reimbursement Requests based on their dateCreated order
+UPDATE "Reimbursement_Request" AS rr
+SET "identifier" = "cte_table".new_identifier
+FROM cte_table
+WHERE rr."reimbursementRequestId" = "cte_table"."reimbursementRequestId";
+
+-- CreateIndex
+CREATE UNIQUE INDEX "Reimbursement_Request_identifier_key" ON "Reimbursement_Request"("identifier");
+
+-- Remove the temporary table
+DROP TABLE cte_table;

src/backend/src/prisma/schema.prisma

@@ -419,6 +419,7 @@ model Receipt {
 
 model Reimbursement_Request {
   reimbursementRequestId String                  @id @default(uuid())
+  identifier             Int                     @unique @default(autoincrement())
   saboId                 Int?                    @unique
   dateCreated            DateTime                @default(now())
   dateDeleted            DateTime?

src/backend/src/prisma/seed.ts

@@ -957,6 +957,27 @@ const performSeed: () => Promise<void> = async () => {
     100
   );
 
+  await ReimbursementRequestService.createReimbursementRequest(
+    thomasEmrax,
+    new Date(),
+    vendor.vendorId,
+    ClubAccount.BUDGET,
+    [],
+    [
+      {
+        name: 'BOX',
+        reason: {
+          carNumber: 1,
+          projectNumber: 1,
+          workPackageNumber: 0
+        },
+        cost: 10000
+      }
+    ],
+    expenseType.expenseTypeId,
+    200
+  );
+
   /**
    * Bill of Materials
    */

src/backend/src/transformers/reimbursement-requests.transformer.ts

@@ -43,6 +43,7 @@ export const reimbursementRequestTransformer = (
 ): ReimbursementRequest => {
   return {
     reimbursementRequestId: reimbursementRequest.reimbursementRequestId,
+    identifier: reimbursementRequest.identifier,
     saboId: reimbursementRequest.saboId ?? undefined,
     dateCreated: reimbursementRequest.dateCreated,
     dateDeleted: reimbursementRequest.dateDeleted ?? undefined,

src/backend/tests/test-data/reimbursement-requests.test-data.ts

@@ -43,6 +43,7 @@ export const Parts: PrismaExpenseType = {
 
 export const GiveMeMyMoney: PrismaReimbursementRequest = {
   reimbursementRequestId: '',
+  identifier: 1,
   saboId: null,
   dateCreated: new Date('20/8/2023'),
   dateDeleted: null,
@@ -57,6 +58,7 @@ export const GiveMeMyMoney: PrismaReimbursementRequest = {
 
 export const GiveMeMyMoney2: PrismaReimbursementRequest = {
   reimbursementRequestId: '',
+  identifier: 2,
   saboId: null,
   dateCreated: new Date('20/8/2023'),
   dateDeleted: new Date('25/8/2023'),
@@ -210,6 +212,7 @@ export const prismaGiveMeMyMoney3Approved: Prisma.Reimbursement_RequestGetPayloa
 
 export const sharedGiveMeMyMoney: ReimbursementRequest = {
   reimbursementRequestId: GiveMeMyMoney.reimbursementRequestId,
+  identifier: GiveMeMyMoney.identifier,
   dateCreated: GiveMeMyMoney.dateCreated,
   dateOfExpense: GiveMeMyMoney.dateOfExpense,
   totalCost: GiveMeMyMoney.totalCost,

src/shared/src/types/reimbursement-requests-types.ts

@@ -31,6 +31,7 @@ export interface Receipt {
 
 export interface ReimbursementRequest {
   reimbursementRequestId: string;
+  identifier: number;
   saboId?: number;
   dateCreated: Date;
   dateDeleted?: Date;