#1592 Use CR Tranformer

Author: Peyton-McKee

src/backend/src/routes/projects.routes.ts

@@ -18,6 +18,7 @@ projectRouter.post(
   validateInputs,
   ProjectsController.createProject
 );
+
 projectRouter.post(
   '/edit',
   intMinZero(body('projectId')),

src/backend/src/services/change-requests.services.ts

@@ -1,7 +1,5 @@
 import {
   ChangeRequest,
-  ChangeRequestReason,
-  ChangeRequestStatus,
   isAdmin,
   isGuest,
   isLeadership,
@@ -603,7 +601,7 @@ export default class ChangeRequestsService {
       );
     });
 
-    const createdProposedSolutions = await Promise.all(proposedSolutionPromises);
+    await Promise.all(proposedSolutionPromises);
 
     const project = createdCR.wbsElement.workPackage?.project || createdCR.wbsElement.project;
     const teams = project?.teams;
@@ -618,28 +616,12 @@ export default class ChangeRequestsService {
       await Promise.all(completion);
     }
 
-    return {
-      ...createdCR,
-      what,
-      why: why.map((why) => ({ explain: why.explain, type: why.type as ChangeRequestReason })),
-      type,
-      wbsNum: {
-        carNumber,
-        projectNumber,
-        workPackageNumber
-      },
-      wbsName: wbsElement.name,
-      submitter,
-      status: ChangeRequestStatus.Open,
-      requestedReviewers: [],
-      dateReviewed: undefined,
-      accepted: undefined,
-      reviewNotes: undefined,
-      scopeImpact: '',
-      budgetImpact: 0,
-      timelineImpact: 0,
-      proposedSolutions: createdProposedSolutions
-    };
+    const finishedCR = await prisma.change_Request.findUnique({
+      where: { crId: createdCR.crId },
+      ...changeRequestQueryArgs
+    });
+
+    return changeRequestTransformer(finishedCR!) as StandardChangeRequest;
   }
 
   /**

src/backend/src/transformers/change-requests.transformer.ts

@@ -62,4 +62,4 @@ const changeRequestTransformer = (
   };
 };
 
-export default changeRequestTransformer;
+export default changeRequestTransformer;

src/frontend/src/pages/CreateChangeRequestPage/CreateChangeRequest.tsx

@@ -5,7 +5,6 @@
 
 import { useHistory } from 'react-router-dom';
 import { ChangeRequestReason, ChangeRequestType, ProposedSolution, validateWBS } from 'shared';
-import { useAuth } from '../../hooks/auth.hooks';
 import { useCreateStandardChangeRequest } from '../../hooks/change-requests.hooks';
 import { useQuery } from '../../hooks/utils.hooks';
 import { routes } from '../../utils/routes';
@@ -24,15 +23,14 @@ export interface FormInput {
 }
 
 const CreateChangeRequest: React.FC<CreateChangeRequestProps> = () => {
-  const auth = useAuth();
   const query = useQuery();
   const history = useHistory();
   const { isLoading, isError, error, mutateAsync } = useCreateStandardChangeRequest();
   const [proposedSolutions, setProposedSolutions] = useState<ProposedSolution[]>([]);
   const [wbsNum, setWbsNum] = useState(query.get('wbsNum') || '');
   const toast = useToast();
 
-  if (isLoading || !auth.user) return <LoadingIndicator />;
+  if (isLoading) return <LoadingIndicator />;
   if (isError) return <ErrorPage message={error?.message} />;
 
   const handleConfirm = async (data: FormInput) => {