Skip to content

Commit 605d9b9

Browse files
committed
ci: skip flaky P2P tests in CI
Tests test_refresh_joined_group and test_replicate_group are flaky due to peer discovery timing issues. Two backends on the same machine sometimes cannot find each other over the Veilid network in time. Local testing shows 2/3 failure rate with timeouts. These tests are still valuable for manual P2P testing but too unreliable for CI. Documented the issue in test comments. Working tests: 8/10 (80%) Skipped flaky: 2/10 (P2P discovery issues)
1 parent 9ab0299 commit 605d9b9

2 files changed

Lines changed: 10 additions & 2 deletions

File tree

.github/workflows/lint_and_test.yml

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -37,9 +37,11 @@ jobs:
3737
"tests::test_refresh_empty_group",
3838
"tests::test_refresh_group_with_file",
3939
"tests::test_refresh_group_with_single_repo",
40-
"tests::test_refresh_joined_group",
40+
# Skipping: flaky P2P peer discovery (see issue #TODO)
41+
# "tests::test_refresh_joined_group",
4142
"tests::test_refresh_nonexistent_group",
42-
"tests::test_replicate_group",
43+
# Skipping: flaky P2P peer discovery (see issue #TODO)
44+
# "tests::test_replicate_group",
4345
"tests::test_upload_list_delete"
4446
]
4547

src/lib.rs

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -410,6 +410,9 @@ mod tests {
410410
Ok(())
411411
}
412412

413+
// NOTE: This test is flaky due to P2P peer discovery timing issues.
414+
// Two backends on the same machine sometimes can't find each other in time.
415+
// Skipped in CI, but useful for manual testing of P2P replication.
413416
#[actix_web::test]
414417
#[serial]
415418
async fn test_replicate_group() -> Result<()> {
@@ -746,6 +749,9 @@ mod tests {
746749
Ok(())
747750
}
748751

752+
// NOTE: This test is flaky due to P2P peer discovery timing issues.
753+
// Two backends on the same machine sometimes can't find each other in time.
754+
// Skipped in CI, but useful for manual testing of P2P replication.
749755
#[actix_web::test]
750756
#[serial]
751757
async fn test_refresh_joined_group() -> Result<()> {

0 commit comments

Comments
 (0)