Skip to content

Commit 2758b31

Browse files
committed
Prune unrelated channel IDs from exported tags
Signed-off-by: DESKTOP-9AKG4SL\ecomeau <ecomeau@caredx.com>
1 parent be058f6 commit 2758b31

2 files changed

Lines changed: 9 additions & 3 deletions

File tree

server/src/com/mirth/connect/server/api/servlets/ChannelServlet.java

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -312,6 +312,11 @@ protected void addExportData(Channel channel, Map<String, ChannelMetadata> chann
312312
channel.getExportData().setChannelTags(channelTags
313313
.stream()
314314
.filter(tag -> tag.getChannelIds().contains(channel.getId()))
315+
.map(tag -> {
316+
ChannelTag exportTag = new ChannelTag(tag);
317+
exportTag.setChannelIds(Collections.singleton(channel.getId()));
318+
return exportTag;
319+
})
315320
.collect(Collectors.toList()));
316321

317322
channel.getExportData().setDependencyIds(channelDependencies
@@ -347,4 +352,4 @@ private List<CodeTemplateLibrary> getCodeTemplateLibraries() {
347352
}
348353
return codeTemplateLibraries;
349354
}
350-
}
355+
}

server/test/com/mirth/connect/server/api/servlets/ChannelServletTest.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -200,8 +200,8 @@ private void verifyChannel1(Channel channel, boolean includeCodeTemplateLibrarie
200200
assertEquals(Integer.valueOf(7), exportData.getMetadata().getPruningSettings().getPruneContentDays());
201201

202202
assertEquals(2, exportData.getChannelTags().size());
203-
assertTrue(exportData.getChannelTags().contains(new ChannelTag("tag1", "Tag 1", new HashSet<>(Arrays.asList(new String[] { CHANNEL_ID_1, CHANNEL_ID_2 })))));
204-
assertTrue(exportData.getChannelTags().contains(new ChannelTag("tag2", "Tag 2", new HashSet<>(Arrays.asList(new String[] { CHANNEL_ID_1, CHANNEL_ID_3 })))));
203+
assertTrue(exportData.getChannelTags().contains(new ChannelTag("tag1", "Tag 1", new HashSet<>(Arrays.asList(new String[] { CHANNEL_ID_1 })))));
204+
assertTrue(exportData.getChannelTags().contains(new ChannelTag("tag2", "Tag 2", new HashSet<>(Arrays.asList(new String[] { CHANNEL_ID_1 })))));
205205

206206
assertEquals(1, exportData.getDependencyIds().size());
207207
assertTrue(exportData.getDependencyIds().contains(CHANNEL_ID_2));
@@ -234,3 +234,4 @@ protected boolean isUserAuthorized() {
234234
}
235235

236236
}
237+

0 commit comments

Comments
 (0)