build: fail build if tests fail

This will allow all tests for a given sub-project to finish, but will
abort the rest of the build.

Previously the build would finish successfully even if there were test
failures.

Issue: #144
Signed-off-by: Tony Germano <tony@germano.name>

Author: tonygermano

client/ant-build.xml

@@ -359,7 +359,7 @@
 		<mkdir dir="${code-coverage-reports}" />
 
 		<jacoco:coverage destfile="${code-coverage-reports}/jacoco.exec" xmlns:jacoco="antlib:org.jacoco.ant" exclclassloader="sun.reflect.DelegatingClassLoader:javassist.Loader" >
-			<junit haltonfailure="false" fork="true" forkmode="once">
+			<junit haltonfailure="false" failureproperty="test.failed" errorproperty="test.failed" fork="true" forkmode="once">
 				<jvmarg value="-Xms128m" />
 				<jvmarg value="-Xmx2048m" />
 				<!-- https://stackoverflow.com/questions/54205486 -->
@@ -376,6 +376,8 @@
 				</batchtest>
 			</junit>
 		</jacoco:coverage>
+
+		<fail if="test.failed" message="Unit tests failed. Check reports for details."/>
 	</target>
 
 	<target name="remove-classes" depends="init">

command/build.xml

@@ -98,7 +98,7 @@
 		<mkdir dir="${code-coverage-reports}" />
 
 		<jacoco:coverage destfile="${code-coverage-reports}/jacoco.exec" xmlns:jacoco="antlib:org.jacoco.ant" exclclassloader="sun.reflect.DelegatingClassLoader:javassist.Loader" >
-			<junit haltonfailure="false" fork="true" forkmode="once">
+			<junit haltonfailure="false" failureproperty="test.failed" errorproperty="test.failed" fork="true" forkmode="once">
 				<jvmarg value="-Xms128m" />
 				<jvmarg value="-Xmx2048m" />
 				<!-- https://stackoverflow.com/questions/54205486 -->
@@ -115,5 +115,7 @@
 				</batchtest>
 			</junit>
 		</jacoco:coverage>
+
+		<fail if="test.failed" message="Unit tests failed. Check reports for details."/>
 	</target>
 </project>

donkey/build.xml

@@ -97,7 +97,7 @@
 		<mkdir dir="${code-coverage-reports}" />
 
 		<jacoco:coverage destfile="${code-coverage-reports}/jacoco.exec" xmlns:jacoco="antlib:org.jacoco.ant" exclclassloader="sun.reflect.DelegatingClassLoader:javassist.Loader" >
-			<junit haltonfailure="false" fork="true" forkmode="once">
+			<junit haltonfailure="false" failureproperty="test.failed" errorproperty="test.failed" fork="true" forkmode="once">
 				<jvmarg value="-Xms128m" />
 				<jvmarg value="-Xmx2048m" />
 				<!-- https://stackoverflow.com/questions/54205486 -->
@@ -114,6 +114,8 @@
 				</batchtest>
 			</junit>
 		</jacoco:coverage>
+
+		<fail if="test.failed" message="Unit tests failed. Check reports for details."/>
 	</target>
 
 	<target name="remove-classes" depends="init">

server/build.xml

@@ -1317,7 +1317,7 @@
 		<mkdir dir="${junit-html}" />
 
 		<jacoco:coverage destfile="${code-coverage-reports}/jacoco.exec" xmlns:jacoco="antlib:org.jacoco.ant" exclclassloader="sun.reflect.DelegatingClassLoader:javassist.Loader" >
-			<junit haltonfailure="false" fork="true" forkmode="once">
+			<junit haltonfailure="false" failureproperty="test.failed" errorproperty="test.failed" fork="true" forkmode="once">
 				<jvmarg value="-Xms128m" />
 				<jvmarg value="-Xmx2048m" />
 				<!-- https://stackoverflow.com/questions/54205486 -->
@@ -1356,6 +1356,8 @@
 			</fileset>
 			<report format="frames" todir="${junit-html}" />
 		</junitreport>
+
+                <fail if="test.failed" message="Unit tests failed. Check reports for details."/>
 	</target>
 
 	<target name="remove-classes" depends="init">