Infinite Loop in cfIEEE1284NormalizeMakeModel used with device_id on empty MFG and MDL

[belayaav]

I've discovered this issue while has been testing GHSA-rcq7-rv5g-j3r4

According to note in ieee1284.c we can give deviceID on input of cfIEEE1284NormalizeMakeModel:

 cfIEEE1284NormalizeMakeModel(
 640     const char *make_and_model,         // I - Original make-and-model string
 641                                         //     or device ID

So I've tried it to understand how it works and discovered that if cfIEEE1284NormalizeMakeModel receives the line with empty MFG and MDL on input, it goes to infinite loop. It reproduces even if line has other not empty values, like CMD. My examples are:

"MFG:;MDL:;"
"MFG:;MDL:;CMD:PostScript;"

Loop doesn't reproduce with line:

"MDL:;"

Both MFG and MDL values should be empty.

I cannot assess a severity of this issue, as I cannot fully understand if using cfIEEE1284NormalizeMakeModel with deviceID is life-case scenario, so advice is appreciated.

Steps to reproduce:

1. I've defined function as:

static int
run_device_id_case(const char *device_id)
{
  char output[OUTPUT_SIZE];
  char *result;

  memset(output, 0, sizeof(output));

  result = cfIEEE1284NormalizeMakeModel(
      device_id,                       
      NULL,                            
      CF_IEEE1284_NORMALIZE_HUMAN,
      NULL,
      output,
      sizeof(output),
      NULL,
      NULL,
      NULL);

  if (result == NULL)
    printf("    Result: NULL\n");
  else
    printf("    Result: \"%s\"\n", result);

  fflush(stdout);
  return 0;
}

2. Input data:

static const test_case_t tests[] =
  {
    {
      "Corrupted device_id",
      TEST_DEVICE_ID,
      "MFG:;MDL:;"
    },

3. Run test

Result: Function hanged

Expected result: Corrupted data was filtered or function exits with error code

I can attach my script if it'll help to reproduce.

[KHARSHAVARDHAN-eng]

@belayaav , Hi! I’d like to investigate this issue and work on a fix. I’ll first try to reproduce the infinite loop and understand the root cause in cfIEEE1284NormalizeMakeModel(). If that goes well, I’d be happy to submit a PR with a regression test and fix.

[belayaav]

@belayaav , Hi! I’d like to investigate this issue and work on a fix. I’ll first try to reproduce the infinite loop and understand the root cause in cfIEEE1284NormalizeMakeModel(). If that goes well, I’d be happy to submit a PR with a regression test and fix.

Thank you!

[KHARSHAVARDHAN-eng]

@belayaav , Implemented the fix for issue #214 and added a dedicated regression test.

The test covers the reported cases with empty MFG and MDL fields and is included in the automated test suite. I also verified the fix with the project's build and test workflow.

Any feedback or suggestions are welcome. Thank you!