Migrate bundled module specs from mocha to rspec-mocks

The ci:modules rake task had silently been a no-op since commit 722532c
removed the per-module Rakefiles in July 2025. It iterated each bundled
module directory and shelled out to rake spec, which walked up to the top
level Rakefile and errored out because no spec task was defined there.

Rewrite ci:modules to invoke rspec directly, update each module spec_helper
to configure rspec-puppet with a proper module_path, migrate ~420
mocha-style call sites to rspec-mocks, refactor around(:each) +
Puppet.override wrappers into before(:each)/after(:each) push_context
pairs (rspec-mocks rejects double setup from around hooks running before
example.run), and drop mocha from the Gemfile.

Fix test bugs that were silently broken while ci:modules was a no-op:
rename pcp:// test targets to remote:// (pcp transport was removed from
openvox), delete two tests that exercised a dead pcp-only code path in
run_task / run_task_with, correct inventory.get_target typos to
get_targets, fix wait_until_available argument expectation, and require
bolt/target in the prompt spec_helper so Puppet type signatures load.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Signed-off-by: nmburgan <13688219+nmburgan@users.noreply.github.com>

Author: nmburgan

Gemfile

@@ -31,9 +31,10 @@ gem "paint", "~> 2.2"
 
 group(:test) do
   gem "beaker-hostgenerator"
-  gem "mocha", '>= 1.4.0', '< 4'
   gem "rack-test", '>= 1', '< 3'
   gem 'rspec-github', require: false
+  gem 'rspec-puppet', '>= 5', require: false
+  gem 'puppet_fixtures', '>= 0.1', '< 3', require: false
 end
 
 group(:release, optional: true) do

bolt-modules/boltlib/spec/functions/add_facts_spec.rb

@@ -5,18 +5,20 @@
 require 'bolt/inventory'
 
 describe 'add_facts' do
-  include PuppetlabsSpec::Fixtures
+  include SpecFixtures
 
   let(:executor) { Bolt::Executor.new }
   let(:inventory) { Bolt::Inventory.empty }
   let(:target) { inventory.get_target('example') }
   let(:tasks_enabled) { true }
 
-  around(:each) do |example|
+  before(:each) do
     Puppet[:tasks] = tasks_enabled
-    Puppet.override(bolt_executor: executor, bolt_inventory: inventory) do
-      example.run
-    end
+    Puppet.push_context(bolt_executor: executor, bolt_inventory: inventory)
+  end
+
+  after(:each) do
+    Puppet.pop_context
   end
 
   it 'should set a fact on a target' do
@@ -32,7 +34,7 @@
   end
 
   it 'reports the call to analytics' do
-    executor.expects(:report_function_call).with('add_facts')
+    expect(executor).to receive(:report_function_call).with('add_facts')
     is_expected.to run.with_params(target, {})
   end
 

bolt-modules/boltlib/spec/functions/add_to_group_spec.rb

@@ -4,19 +4,21 @@
 require 'bolt/inventory'
 
 describe 'add_to_group' do
-  include PuppetlabsSpec::Fixtures
+  include SpecFixtures
 
   let(:executor) { Bolt::Executor.new }
   let(:inventory) { Bolt::Inventory.empty }
   let(:target) { inventory.get_target('example') }
   let(:group) { 'all' }
   let(:tasks_enabled) { true }
 
-  around(:each) do |example|
+  before(:each) do
     Puppet[:tasks] = tasks_enabled
-    Puppet.override(bolt_executor: executor, bolt_inventory: inventory) do
-      example.run
-    end
+    Puppet.push_context(bolt_executor: executor, bolt_inventory: inventory)
+  end
+
+  after(:each) do
+    Puppet.pop_context
   end
 
   it 'should add a target to group' do
@@ -31,7 +33,7 @@
   end
 
   it 'reports the call to analytics' do
-    executor.expects(:report_function_call).with('add_to_group')
+    expect(executor).to receive(:report_function_call).with('add_to_group')
     is_expected.to run.with_params(target, group)
   end