Rate limits are only known for social.xboxlive.com

This commit removes the rate_limits passing from get_friends_own (peoplehub.xboxlive.com) as it is not explicitly known what rate limits apply to this domain.

This commit adds rate_limits passing all to functions that call social.xboxlive.com:
- get_friends_summary_own
- get_friends_summary_by_xuid
- get_friends_summary_by_gamertag

This commit also updates the test 'test_ratelimits_exceeded_burst_only' to use a function calling social.xboxlive.com
(Test would otherwise break as previous function no longer passes rate_limits)

Author: jcxldn

tests/test_ratelimits.py

@@ -107,12 +107,11 @@ class child_class(RateLimitedProvider):
 @pytest.mark.asyncio
 async def test_ratelimits_exceeded_burst_only(respx_mock, xbl_client):
     async def make_request():
-        route = respx_mock.get("https://peoplehub.xboxlive.com").mock(
-            return_value=Response(200, json=get_response_json("people_friends_own"))
+        route = respx_mock.get("https://social.xboxlive.com").mock(
+            return_value=Response(200, json=get_response_json("people_summary_own"))
         )
-        ret = await xbl_client.people.get_friends_own()
+        ret = await xbl_client.people.get_friends_summary_own()
 
-        assert len(ret.people) == 2
         assert route.called
 
     # Record the start time to ensure that the timeouts are the correct length

xbox/webapi/api/provider/people/__init__.py

@@ -21,6 +21,7 @@ class PeopleProvider(RateLimitedProvider):
     }
     SEPERATOR = ","
 
+    # NOTE: Rate Limits are noted for social.xboxlive.com ONLY
     RATE_LIMITS = {"burst": 10, "sustain": 30}
 
     def __init__(self, client):
@@ -53,9 +54,7 @@ async def get_friends_own(
         decoration = self.SEPERATOR.join(decoration_fields)
 
         url = f"{self.PEOPLE_URL}/users/me/people/social/decoration/{decoration}"
-        resp = await self.client.session.get(
-            url, headers=self._headers, rate_limits=self.rate_limit_read, **kwargs
-        )
+        resp = await self.client.session.get(url, headers=self._headers, **kwargs)
         resp.raise_for_status()
         return PeopleResponse(**resp.json())
 
@@ -133,7 +132,9 @@ async def get_friends_summary_own(self, **kwargs) -> PeopleSummaryResponse:
             :class:`PeopleSummaryResponse`: People Summary Response
         """
         url = self.SOCIAL_URL + "/users/me/summary"
-        resp = await self.client.session.get(url, headers=self.HEADERS_SOCIAL, **kwargs)
+        resp = await self.client.session.get(
+            url, headers=self.HEADERS_SOCIAL, rate_limits=self.rate_limit_read, **kwargs
+        )
         resp.raise_for_status()
         return PeopleSummaryResponse(**resp.json())
 
@@ -150,7 +151,9 @@ async def get_friends_summary_by_xuid(
             :class:`PeopleSummaryResponse`: People Summary Response
         """
         url = self.SOCIAL_URL + f"/users/xuid({xuid})/summary"
-        resp = await self.client.session.get(url, headers=self.HEADERS_SOCIAL, **kwargs)
+        resp = await self.client.session.get(
+            url, headers=self.HEADERS_SOCIAL, rate_limits=self.rate_limit_read, **kwargs
+        )
         resp.raise_for_status()
         return PeopleSummaryResponse(**resp.json())
 
@@ -167,6 +170,8 @@ async def get_friends_summary_by_gamertag(
             :class:`PeopleSummaryResponse`: People Summary Response
         """
         url = self.SOCIAL_URL + f"/users/gt({gamertag})/summary"
-        resp = await self.client.session.get(url, headers=self.HEADERS_SOCIAL, **kwargs)
+        resp = await self.client.session.get(
+            url, headers=self.HEADERS_SOCIAL, rate_limits=self.rate_limit_read, **kwargs
+        )
         resp.raise_for_status()
         return PeopleSummaryResponse(**resp.json())