Skip to content

Commit b95e4cc

Browse files
SR20290919SR20290919
authored andcommitted
adding code rabbit suggestions
1 parent f5ca14c commit b95e4cc

1 file changed

Lines changed: 9 additions & 4 deletions

File tree

src/main/java/com/iemr/common/service/grievance/GrievanceHandlingServiceImpl.java

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -464,8 +464,14 @@ public String getGrievanceDetailsWithRemarks(String request) throws Exception {
464464
remarks = fetchRemarksFromGrievanceWorklist(grievance.getComplaintID());
465465
} else {
466466
// Default: Fetch remarks based on the grievance's specific conditions (no specific resolution status)
467-
// remarks = fetchRemarksBasedOnConditions(grievance.getComplaintID());
468-
remarks = fetchRemarksFromBenCallByComplaint(grievance.getComplaintID());
467+
String callRemarks = fetchRemarksFromBenCallByComplaint(grievance.getComplaintID());
468+
if(remarks != null && !remarks.startsWith("No remarks found")) {
469+
remarks = callRemarks;
470+
}
471+
else {
472+
remarks = fetchRemarksFromGrievanceWorklist(grievance.getComplaintID());
473+
474+
}
469475
}
470476

471477
grievanceResponse.setRemarks(remarks);
@@ -475,12 +481,11 @@ public String getGrievanceDetailsWithRemarks(String request) throws Exception {
475481
}
476482

477483
// Convert the list of GrievanceResponse objects to JSON and return as a string
478-
// ObjectMapper objectMapper = new ObjectMapper();
479484
return objectMapper.writeValueAsString(grievanceResponseList);
480485

481486
} catch (Exception e) {
482487
logger.error("Error while getting grievance details with remarks: " + e.getMessage(), e);
483-
return "Error fetching grievance details with remarks: " + e.getMessage();
488+
throw new Exception("Error processing grievance request");
484489
}
485490
}
486491

0 commit comments

Comments
 (0)