Feature PS-9868:

Configure tox to run tests on different environments.
Fix some issue with code on different python versions.

Author: MudlaffP

Pipfile

@@ -14,6 +14,7 @@ gradient-statsd = "*"
 click = "*"
 terminaltables = "*"
 colorclass = "*"
+tox = "*"
 
 [dev-packages]
 twine = "*"

Pipfile.lock

@@ -14,8 +14,9 @@ class ListLogsCommand(CommandBase):
     is_logs_complete = False
 
     def execute(self, job_id):
+        table_title = "Job %s logs" % job_id
         table_data = [("LINE", "MESSAGE")]
-        table = terminaltables.AsciiTable(table_data, title=f"Job {job_id} logs")
+        table = terminaltables.AsciiTable(table_data, title=table_title)
 
         while not self.is_logs_complete:
             response = self._get_logs(job_id)

paperspace/commands/logs.py

@@ -2247,3 +2247,51 @@
     "experimentId": "es47og38wzhnuo"
   }
 ]
+
+LIST_OF_LOGS_FOR_JOB = [
+    {
+        "line": 1,
+        "timestamp": "2019-04-03T15:56:35.457Z",
+        "message": "Traceback (most recent call last):"
+    }, {
+        "line": 2,
+        "timestamp": "2019-04-03T15:56:35.458Z",
+        "message": "  File \"generate_figures.py\", line 15, in \u003cmodule\u003e"
+    }, {
+        "line": 3,
+        "timestamp": "2019-04-03T15:56:35.458Z",
+        "message": "    import dnnlib.tflib as tflib"
+    }, {
+        "line": 4,
+        "timestamp": "2019-04-03T15:56:35.458Z",
+        "message": "  File \"/paperspace/dnnlib/tflib/__init__.py\", line 8, in \u003cmodule\u003e"
+    }, {
+        "line": 5,
+        "timestamp": "2019-04-03T15:56:35.458Z",
+        "message": "    from . import autosummary"
+    }, {
+        "line": 6,
+        "timestamp": "2019-04-03T15:56:35.458Z",
+        "message": "  File \"/paperspace/dnnlib/tflib/autosummary.py\", line 31, in \u003cmodule\u003e"
+    }, {
+        "line": 7,
+        "timestamp": "2019-04-03T15:56:35.458Z",
+        "message": "    from . import tfutil"
+    }, {
+        "line": 8,
+        "timestamp": "2019-04-03T15:56:35.458Z",
+        "message": "  File \"/paperspace/dnnlib/tflib/tfutil.py\", line 34, in \u003cmodule\u003e"
+    }, {
+        "line": 9,
+        "timestamp": "2019-04-03T15:56:35.458Z",
+        "message": "    def shape_to_list(shape: Iterable[tf.Dimension]) -\u003e List[Union[int, None]]:"
+    }, {
+        "line": 10,
+        "timestamp": "2019-04-03T15:56:35.458Z",
+        "message": "AttributeError: module 'tensorflow' has no attribute 'Dimension'"
+    }, {
+        "line": 11,
+        "timestamp": "2019-04-03T15:56:46.168Z",
+        "message": "PSEOF"
+    }
+]

tests/example_responses.py

@@ -0,0 +1,44 @@
+import mock
+from click.testing import CliRunner
+
+from paperspace.cli import cli
+from paperspace.client import default_headers
+from tests import MockResponse, example_responses
+
+
+class TestListLogs(object):
+    URL = "https://logs.paperspace.io"
+    EXPECTED_HEADERS = default_headers.copy()
+    EXPECTED_RESPONSE_JSON = example_responses.LIST_OF_LOGS_FOR_JOB
+    BASIC_COMMAND = ["logs", "list"]
+    EXPECTED_STDOUT = """+Job jztdeungdkzjv logs------------------------------------------------------------------+
+| LINE | MESSAGE                                                                         |
++------+---------------------------------------------------------------------------------+
+| 1    | Traceback (most recent call last):                                              |
+| 2    |   File "generate_figures.py", line 15, in <module>                              |
+| 3    |     import dnnlib.tflib as tflib                                                |
+| 4    |   File "/paperspace/dnnlib/tflib/__init__.py", line 8, in <module>              |
+| 5    |     from . import autosummary                                                   |
+| 6    |   File "/paperspace/dnnlib/tflib/autosummary.py", line 31, in <module>          |
+| 7    |     from . import tfutil                                                        |
+| 8    |   File "/paperspace/dnnlib/tflib/tfutil.py", line 34, in <module>               |
+| 9    |     def shape_to_list(shape: Iterable[tf.Dimension]) -> List[Union[int, None]]: |
+| 10   | AttributeError: module 'tensorflow' has no attribute 'Dimension'                |
+| 11   | PSEOF                                                                           |
++------+---------------------------------------------------------------------------------+
+"""
+
+    @mock.patch("paperspace.cli.cli.client.requests.get")
+    def test_should_send_valid_get_request_and_print_table_with_logs(self, get_patched):
+        get_patched.return_value = MockResponse(json_data=self.EXPECTED_RESPONSE_JSON, status_code=200)
+
+        cli_runner = CliRunner()
+        result = cli_runner.invoke(cli.cli, self.BASIC_COMMAND)
+
+        get_patched.assert_called_with(self.URL,
+                                       headers=self.EXPECTED_HEADERS,
+                                       json=None,
+                                       params=None)
+
+        assert result.output == self.EXPECTED_STDOUT
+        assert result.exit_code == 0

tests/functional/test_logs.py

@@ -0,0 +1,37 @@
+[run]
+omit = tests/*
+
+[tool:pytest]
+addopts = --cov=paperspace
+
+[tox]
+envlist =
+    check
+    {py27,py34,py35,py36,py37}-{pt44}-{ptc26}
+skip_missing_interpreters = True
+
+[testenv]
+changedir = tests
+
+extras = testing
+setenv =
+    PYTHONUNBUFFERED=yes
+passenv =
+    *
+deps =
+    mock
+    pt44: pytest==4.4.1
+
+    ptc26: pytest-cov==2.6.1
+pip_pre = true
+
+commands =
+    pytest --cov=paperspace --cov-append
+
+[testenv:check]
+deps =
+    flake8
+skip_install = true
+usedevelop = false
+commands =
+    flake8 paperspace tests setup.py