From 22d84158a943f09906c2a9b4473d91696143d5bd Mon Sep 17 00:00:00 2001 From: Furkan Davulcu Date: Fri, 26 Jun 2026 09:40:52 +0200 Subject: [PATCH 1/2] fix: add trailing newline to git-lfs .gitattributes files Unblocks the pre-commit end-of-file-fixer hook, which CI runs with --all-files and which fails on git-lfs-generated .gitattributes that lack a final newline. Co-Authored-By: Claude Opus 4.8 (1M context) --- src/factory_sim/objectives/.gitattributes | 2 +- src/hangar_sim/description/assets/.gitattributes | 2 +- src/hangar_sim/images/.gitattributes | 2 +- src/hangar_sim/maps/.gitattributes | 2 +- .../mujoco/assets/kitchen_assets/textures/.gitattributes | 2 +- .../kinova_sim/description/mujoco/assets/.gitattributes | 2 +- .../description/mujoco/assets/.gitattributes | 2 +- .../description/mujoco/assets/.gitattributes | 2 +- src/moveit_pro_ur_configs/mock_sim/meshes/.gitattributes | 2 +- 9 files changed, 9 insertions(+), 9 deletions(-) diff --git a/src/factory_sim/objectives/.gitattributes b/src/factory_sim/objectives/.gitattributes index dd589a756..7db549b5c 100644 --- a/src/factory_sim/objectives/.gitattributes +++ b/src/factory_sim/objectives/.gitattributes @@ -1 +1 @@ -*.{png,jpg,jpeg,obj,dae,stl,OBJ,DAE,STL} filter=lfs diff=lfs merge=lfs -text \ No newline at end of file +*.{png,jpg,jpeg,obj,dae,stl,OBJ,DAE,STL} filter=lfs diff=lfs merge=lfs -text diff --git a/src/hangar_sim/description/assets/.gitattributes b/src/hangar_sim/description/assets/.gitattributes index dd589a756..7db549b5c 100644 --- a/src/hangar_sim/description/assets/.gitattributes +++ b/src/hangar_sim/description/assets/.gitattributes @@ -1 +1 @@ -*.{png,jpg,jpeg,obj,dae,stl,OBJ,DAE,STL} filter=lfs diff=lfs merge=lfs -text \ No newline at end of file +*.{png,jpg,jpeg,obj,dae,stl,OBJ,DAE,STL} filter=lfs diff=lfs merge=lfs -text diff --git a/src/hangar_sim/images/.gitattributes b/src/hangar_sim/images/.gitattributes index dd589a756..7db549b5c 100644 --- a/src/hangar_sim/images/.gitattributes +++ b/src/hangar_sim/images/.gitattributes @@ -1 +1 @@ -*.{png,jpg,jpeg,obj,dae,stl,OBJ,DAE,STL} filter=lfs diff=lfs merge=lfs -text \ No newline at end of file +*.{png,jpg,jpeg,obj,dae,stl,OBJ,DAE,STL} filter=lfs diff=lfs merge=lfs -text diff --git a/src/hangar_sim/maps/.gitattributes b/src/hangar_sim/maps/.gitattributes index dd589a756..7db549b5c 100644 --- a/src/hangar_sim/maps/.gitattributes +++ b/src/hangar_sim/maps/.gitattributes @@ -1 +1 @@ -*.{png,jpg,jpeg,obj,dae,stl,OBJ,DAE,STL} filter=lfs diff=lfs merge=lfs -text \ No newline at end of file +*.{png,jpg,jpeg,obj,dae,stl,OBJ,DAE,STL} filter=lfs diff=lfs merge=lfs -text diff --git a/src/moveit_pro_franka_configs/kitchen_sim/description/mujoco/assets/kitchen_assets/textures/.gitattributes b/src/moveit_pro_franka_configs/kitchen_sim/description/mujoco/assets/kitchen_assets/textures/.gitattributes index dd589a756..7db549b5c 100644 --- a/src/moveit_pro_franka_configs/kitchen_sim/description/mujoco/assets/kitchen_assets/textures/.gitattributes +++ b/src/moveit_pro_franka_configs/kitchen_sim/description/mujoco/assets/kitchen_assets/textures/.gitattributes @@ -1 +1 @@ -*.{png,jpg,jpeg,obj,dae,stl,OBJ,DAE,STL} filter=lfs diff=lfs merge=lfs -text \ No newline at end of file +*.{png,jpg,jpeg,obj,dae,stl,OBJ,DAE,STL} filter=lfs diff=lfs merge=lfs -text diff --git a/src/moveit_pro_kinova_configs/kinova_sim/description/mujoco/assets/.gitattributes b/src/moveit_pro_kinova_configs/kinova_sim/description/mujoco/assets/.gitattributes index dd589a756..7db549b5c 100644 --- a/src/moveit_pro_kinova_configs/kinova_sim/description/mujoco/assets/.gitattributes +++ b/src/moveit_pro_kinova_configs/kinova_sim/description/mujoco/assets/.gitattributes @@ -1 +1 @@ -*.{png,jpg,jpeg,obj,dae,stl,OBJ,DAE,STL} filter=lfs diff=lfs merge=lfs -text \ No newline at end of file +*.{png,jpg,jpeg,obj,dae,stl,OBJ,DAE,STL} filter=lfs diff=lfs merge=lfs -text diff --git a/src/moveit_pro_kinova_configs/space_satellite_sim/description/mujoco/assets/.gitattributes b/src/moveit_pro_kinova_configs/space_satellite_sim/description/mujoco/assets/.gitattributes index dd589a756..7db549b5c 100644 --- a/src/moveit_pro_kinova_configs/space_satellite_sim/description/mujoco/assets/.gitattributes +++ b/src/moveit_pro_kinova_configs/space_satellite_sim/description/mujoco/assets/.gitattributes @@ -1 +1 @@ -*.{png,jpg,jpeg,obj,dae,stl,OBJ,DAE,STL} filter=lfs diff=lfs merge=lfs -text \ No newline at end of file +*.{png,jpg,jpeg,obj,dae,stl,OBJ,DAE,STL} filter=lfs diff=lfs merge=lfs -text diff --git a/src/moveit_pro_kinova_configs/space_satellite_sim_camera_cal/description/mujoco/assets/.gitattributes b/src/moveit_pro_kinova_configs/space_satellite_sim_camera_cal/description/mujoco/assets/.gitattributes index dd589a756..7db549b5c 100644 --- a/src/moveit_pro_kinova_configs/space_satellite_sim_camera_cal/description/mujoco/assets/.gitattributes +++ b/src/moveit_pro_kinova_configs/space_satellite_sim_camera_cal/description/mujoco/assets/.gitattributes @@ -1 +1 @@ -*.{png,jpg,jpeg,obj,dae,stl,OBJ,DAE,STL} filter=lfs diff=lfs merge=lfs -text \ No newline at end of file +*.{png,jpg,jpeg,obj,dae,stl,OBJ,DAE,STL} filter=lfs diff=lfs merge=lfs -text diff --git a/src/moveit_pro_ur_configs/mock_sim/meshes/.gitattributes b/src/moveit_pro_ur_configs/mock_sim/meshes/.gitattributes index dd589a756..7db549b5c 100644 --- a/src/moveit_pro_ur_configs/mock_sim/meshes/.gitattributes +++ b/src/moveit_pro_ur_configs/mock_sim/meshes/.gitattributes @@ -1 +1 @@ -*.{png,jpg,jpeg,obj,dae,stl,OBJ,DAE,STL} filter=lfs diff=lfs merge=lfs -text \ No newline at end of file +*.{png,jpg,jpeg,obj,dae,stl,OBJ,DAE,STL} filter=lfs diff=lfs merge=lfs -text From 92ec2b6952ec5995547dc7bfa666ae1690a981d5 Mon Sep 17 00:00:00 2001 From: Furkan Davulcu Date: Tue, 30 Jun 2026 12:50:52 +0200 Subject: [PATCH 2/2] fix(lab_sim): re-skip renamed Marker Visualization Example objective Co-Authored-By: Claude Opus 4.8 (1M context) --- src/lab_sim/test/objectives_integration_test.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/lab_sim/test/objectives_integration_test.py b/src/lab_sim/test/objectives_integration_test.py index b7cc48271..adddcf6ff 100644 --- a/src/lab_sim/test/objectives_integration_test.py +++ b/src/lab_sim/test/objectives_integration_test.py @@ -76,7 +76,7 @@ "Inspector", "Pick 1 Pill Bottle", "AddBottlesToPlanningScene", - "Interactive Marker Visualization", # Server not available for GetTextFromUser + "Marker Visualization Example", # Server not available for GetTextFromUser "Octomap Example", # Requires user input to clear the octomap. }