You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The #195 and #204 reviews both flagged the same latent seam, neither blocking its own PR; filing it so the C1/C2 freeze checklist owns it.
banding.py's coding argument defaults to "ipums_firmsize" (banding.py:256). The per-vintage guards make NOEMP-only codes raise loudly, but three codes are valid in both code spaces and silently mis-band if a NOEMP caller omits coding:
2011–2018 code 4 → banded B10_49, true band B100_499
2011–2018 code 6 → banded B50_99, true band B500_PLUS
2019+ code 5 → banded B10_49/B50_99 straddle, true band B500_PLUS
Latent today because #204's reader does not call banding yet; it becomes active the moment the ASEC NOEMP output meets the target pipeline.
Two closes on the table (either satisfies both reviews):
The #195 and #204 reviews both flagged the same latent seam, neither blocking its own PR; filing it so the C1/C2 freeze checklist owns it.
banding.py'scodingargument defaults to"ipums_firmsize"(banding.py:256). The per-vintage guards make NOEMP-only codes raise loudly, but three codes are valid in both code spaces and silently mis-band if a NOEMP caller omitscoding:Latent today because #204's reader does not call
bandingyet; it becomes active the moment the ASEC NOEMP output meets the target pipeline.Two closes on the table (either satisfies both reviews):
CanonicalBanddirectly vianoemp_to_canonical(the option daphnehanse11 offered on the Employer-firm Workstream B: canonical banding (C2), ADR 0003, target pipeline (#192) #195 thread), so no downstream caller ever passes raw NOEMP codes tobanding— preferred.codingdefault inbanding.pyso callers must state the code space.Refs: the #195 review (approval notes, residual item) and the #204 review (approval notes). Should be closed before the joint C1/C2 freeze sign-off.