fix(mcp): address PR 121 review comments

- filterTestRunOutput: split on /\r?\n/ and strip trailing \r so
  Windows CRLF output does not leave stray \r chars or break noise
  pattern matching (Copilot suggestion)
- rcaTools run_index schema: add .int().positive() validation on both
  provar.testrun.report.locate and provar.testrun.rca to reject
  run_index <= 0 before it reaches resolveResultsLocation (Copilot suggestion)
- test: add CRLF-safety test for filterTestRunOutput

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Author: mrdailey99

src/mcp/tools/automationTools.ts

@@ -177,12 +177,13 @@ const NOISE_PATTERNS: RegExp[] = [
  * Returns the filtered text and the count of suppressed lines.
  */
 export function filterTestRunOutput(raw: string): { filtered: string; suppressed: number } {
-  const lines = raw.split('\n');
+  const lines = raw.split(/\r?\n/);
   const kept: string[] = [];
   let suppressed = 0;
   let lastKeptWasBlank = false;
 
-  for (const line of lines) {
+  for (const rawLine of lines) {
+    const line = rawLine.endsWith('\r') ? rawLine.slice(0, -1) : rawLine;
     if (NOISE_PATTERNS.some((p) => p.test(line))) {
       suppressed++;
       continue;

src/mcp/tools/rcaTools.ts

@@ -401,8 +401,10 @@ export function registerTestRunLocate(server: McpServer): void {
         .describe('Explicit override for the results base directory; if provided, skip auto-detection'),
       run_index: z
         .number()
+        .int()
+        .positive()
         .optional()
-        .describe('Which Increment run to target (default: latest)'),
+        .describe('Which Increment run to target (default: latest); must be a positive integer'),
     },
     (input) => {
       const requestId = makeRequestId();
@@ -668,8 +670,10 @@ export function registerTestRunRca(server: McpServer): void {
         .describe('Explicit override for the results base directory'),
       run_index: z
         .number()
+        .int()
+        .positive()
         .optional()
-        .describe('Which Increment run to target (default: latest)'),
+        .describe('Which Increment run to target (default: latest); must be a positive integer'),
       locate_only: z
         .boolean()
         .optional()

test/unit/mcp/automationTools.test.ts

@@ -635,5 +635,14 @@ describe('filterTestRunOutput', () => {
     assert.ok(filtered.includes('line1'), 'Content should be preserved');
     assert.ok(filtered.includes('line2'), 'Content should be preserved');
   });
+
+  it('handles Windows CRLF line endings without leaving trailing \\r', () => {
+    const raw = 'INFO Starting\r\ncom.networknt.schema.JsonSchemaFactory - loaded\r\nINFO Done\r\n';
+    const { filtered, suppressed } = filterTestRunOutput(raw);
+    assert.equal(suppressed, 1, 'CRLF noise line should be suppressed');
+    assert.ok(!filtered.includes('\r'), 'No trailing \\r should remain in output');
+    assert.ok(filtered.includes('INFO Starting'), 'Real output should remain');
+    assert.ok(filtered.includes('INFO Done'), 'Real output should remain');
+  });
 });