M2: consolidated lib spine smoke expansion (#1056)#1454
Closed
PurHur wants to merge 4 commits into
Closed
Conversation
Extend compiler_lib_spine_smoke with seven Builtin units (CallArgv, IniSet, StringFunctionExists, StringHttpBuildQuery, StringSerialize, StringSuperglobalName, StringUrldecode) and drop an unparseable hexNibbleValue docblock that blocked self-host type reconstruction. Co-authored-by: Cursor <cursoragent@cursor.com> (cherry picked from commit 1258208)
Grow compiler_lib_spine_smoke by ten vm.php-path lib units plus is_numeric for Params; fix PHPDoc and closure patterns for self-host AOT lint; extend JIT lib-spine stubs for new Web/Cli hot paths. Co-authored-by: Cursor <cursoragent@cursor.com> (cherry picked from commit 523e12f)
Add deep-wave JIT builtins and helpers to compiler_lib_spine_smoke with targeted AOT stubs and small lowering fixes for self-host parse/compile. Co-authored-by: Cursor <cursoragent@cursor.com> (cherry picked from commit 03d5ffd)
Add 25 ext/standard Jit* leaf modules to compiler_lib_spine_smoke and sync bundle unit counts in BootstrapSelfhostBundleTest and docs. Co-authored-by: Cursor <cursoragent@cursor.com> (cherry picked from commit 11fd1b7)
This was referenced May 24, 2026
Owner
Author
|
Closing as superseded by parallel M2 merges already on Status when checked:
Follow-up: #1454’s few remaining gaps ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Consolidates parallel M2 spine work from #1411, #1412, #1418, #1421 into one mergeable branch.
compiler_lib_spine_smoke(was 157)Test plan
php bin/compile.php -l test/selfhost/compiler_lib_spine_smoke/main.phpphpunit --filter BootstrapSelfhostBundleTest./script/bootstrap-selfhost-lib-spine-smoke-link.sh(LLVM)Made with Cursor