Skip to content

Commit a32c55d

Browse files
mgarcia01752mgarcia01752
committed
Polish CMTS OFDMA pre equalization echo labeling and frequency response presentation
- update echo section wording to Echo Detected and No Echo Detected on modem cards - keep estimated frequency response as primary combined graph context with overlay toggles per modem - preserve upstream OFDMA pre equalization chart and stats layout while improving detection clarity - sync visualizer changes to PyPNM-CMTS collection and regenerate MkDocs visual preview pages - 2026-02-28 21:46:45
1 parent d0f0a80 commit a32c55d

4 files changed

Lines changed: 7 additions & 7 deletions

File tree

‎docs/visual-previews/PyPNM-CMTS/ServingGroup/Upstream/OFDMA/PreEqualization/Results/basic.html‎

Lines changed: 1 addition & 1 deletion
Large diffs are not rendered by default.

‎docs/visual/PyPNM-CMTS/ServingGroup/Upstream/OFDMA/PreEqualization/Results/basic.md‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -400,15 +400,15 @@ const template = `
400400
} else {
401401
const gdEmpty=document.createElement('div'); gdEmpty.className='chart-box small'; gdEmpty.style.display='grid'; gdEmpty.style.placeItems='center'; gdEmpty.style.color='var(--muted)'; gdEmpty.textContent='No Group Delay'; card.appendChild(gdEmpty);
402402
}
403-
const echoLabel=document.createElement('div'); echoLabel.className='chart-label'; echoLabel.textContent='Echo Information'; card.appendChild(echoLabel);
403+
const echoLabel=document.createElement('div'); echoLabel.className='chart-label'; echoLabel.textContent=(row.echoes && row.echoes.length) ? 'Echo Detected' : 'No Echo Detected'; card.appendChild(echoLabel);
404404
if (row.echoes && row.echoes.length) {
405405
const tbl=document.createElement('table'); tbl.className='echo-table';
406406
tbl.innerHTML='<thead><tr><th>Bin</th><th>Time us</th><th>Amplitude</th><th>Distance ft</th></tr></thead><tbody>'+
407407
row.echoes.map((e)=>'<tr><td>'+e.bin+'</td><td>'+e.time_us+'</td><td>'+e.amplitude+'</td><td>'+e.dist_ft+'</td></tr>').join('')+
408408
'</tbody>';
409409
card.appendChild(tbl);
410410
} else {
411-
const echoEmpty=document.createElement('div'); echoEmpty.className='chart-box small'; echoEmpty.style.height='52px'; echoEmpty.style.display='grid'; echoEmpty.style.placeItems='center'; echoEmpty.style.color='var(--muted)'; echoEmpty.textContent='No Echo Information'; card.appendChild(echoEmpty);
411+
const echoEmpty=document.createElement('div'); echoEmpty.className='chart-box small'; echoEmpty.style.height='52px'; echoEmpty.style.display='grid'; echoEmpty.style.placeItems='center'; echoEmpty.style.color='var(--muted)'; echoEmpty.textContent='No Echo Detected'; card.appendChild(echoEmpty);
412412
}
413413
grid.appendChild(card);
414414
});

‎postman/collections/PyPNM-CMTS.postman_collection.json‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4277,15 +4277,15 @@
42774277
" } else {",
42784278
" const gdEmpty=document.createElement('div'); gdEmpty.className='chart-box small'; gdEmpty.style.display='grid'; gdEmpty.style.placeItems='center'; gdEmpty.style.color='var(--muted)'; gdEmpty.textContent='No Group Delay'; card.appendChild(gdEmpty);",
42794279
" }",
4280-
" const echoLabel=document.createElement('div'); echoLabel.className='chart-label'; echoLabel.textContent='Echo Information'; card.appendChild(echoLabel);",
4280+
" const echoLabel=document.createElement('div'); echoLabel.className='chart-label'; echoLabel.textContent=(row.echoes && row.echoes.length) ? 'Echo Detected' : 'No Echo Detected'; card.appendChild(echoLabel);",
42814281
" if (row.echoes && row.echoes.length) {",
42824282
" const tbl=document.createElement('table'); tbl.className='echo-table';",
42834283
" tbl.innerHTML='<thead><tr><th>Bin</th><th>Time us</th><th>Amplitude</th><th>Distance ft</th></tr></thead><tbody>'+",
42844284
" row.echoes.map((e)=>'<tr><td>'+e.bin+'</td><td>'+e.time_us+'</td><td>'+e.amplitude+'</td><td>'+e.dist_ft+'</td></tr>').join('')+",
42854285
" '</tbody>';",
42864286
" card.appendChild(tbl);",
42874287
" } else {",
4288-
" const echoEmpty=document.createElement('div'); echoEmpty.className='chart-box small'; echoEmpty.style.height='52px'; echoEmpty.style.display='grid'; echoEmpty.style.placeItems='center'; echoEmpty.style.color='var(--muted)'; echoEmpty.textContent='No Echo Information'; card.appendChild(echoEmpty);",
4288+
" const echoEmpty=document.createElement('div'); echoEmpty.className='chart-box small'; echoEmpty.style.height='52px'; echoEmpty.style.display='grid'; echoEmpty.style.placeItems='center'; echoEmpty.style.color='var(--muted)'; echoEmpty.textContent='No Echo Detected'; card.appendChild(echoEmpty);",
42894289
" }",
42904290
" grid.appendChild(card);",
42914291
" });",

‎visual/PyPNM-CMTS/ServingGroup/Upstream/OFDMA/PreEqualization/Results/basic.html‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -383,15 +383,15 @@ <h1 class="title">{{title}}</h1>
383383
} else {
384384
const gdEmpty=document.createElement('div'); gdEmpty.className='chart-box small'; gdEmpty.style.display='grid'; gdEmpty.style.placeItems='center'; gdEmpty.style.color='var(--muted)'; gdEmpty.textContent='No Group Delay'; card.appendChild(gdEmpty);
385385
}
386-
const echoLabel=document.createElement('div'); echoLabel.className='chart-label'; echoLabel.textContent='Echo Information'; card.appendChild(echoLabel);
386+
const echoLabel=document.createElement('div'); echoLabel.className='chart-label'; echoLabel.textContent=(row.echoes && row.echoes.length) ? 'Echo Detected' : 'No Echo Detected'; card.appendChild(echoLabel);
387387
if (row.echoes && row.echoes.length) {
388388
const tbl=document.createElement('table'); tbl.className='echo-table';
389389
tbl.innerHTML='<thead><tr><th>Bin</th><th>Time us</th><th>Amplitude</th><th>Distance ft</th></tr></thead><tbody>'+
390390
row.echoes.map((e)=>'<tr><td>'+e.bin+'</td><td>'+e.time_us+'</td><td>'+e.amplitude+'</td><td>'+e.dist_ft+'</td></tr>').join('')+
391391
'</tbody>';
392392
card.appendChild(tbl);
393393
} else {
394-
const echoEmpty=document.createElement('div'); echoEmpty.className='chart-box small'; echoEmpty.style.height='52px'; echoEmpty.style.display='grid'; echoEmpty.style.placeItems='center'; echoEmpty.style.color='var(--muted)'; echoEmpty.textContent='No Echo Information'; card.appendChild(echoEmpty);
394+
const echoEmpty=document.createElement('div'); echoEmpty.className='chart-box small'; echoEmpty.style.height='52px'; echoEmpty.style.display='grid'; echoEmpty.style.placeItems='center'; echoEmpty.style.color='var(--muted)'; echoEmpty.textContent='No Echo Detected'; card.appendChild(echoEmpty);
395395
}
396396
grid.appendChild(card);
397397
});

0 commit comments

Comments
 (0)