improve tests for like endpoint

Author: arthur-mesquita

app/routers/news/routes.py

@@ -1,16 +1,15 @@
+import os
 from typing import Annotated
 
+import jwt
 from fastapi import APIRouter, Depends, Request, status
 from fastapi.params import Header
 from pydantic import BaseModel
 
+import app.services.database.orm.news as orm_news
 from app.routers.authentication import get_current_active_community
 from app.schemas import News
 from app.services.database.models import Community as DBCommunity
-import app.services.database.orm.news as orm_news
-
-import os
-import jwt
 
 SECRET_KEY = os.getenv("SECRET_KEY", "default_fallback_key")
 ALGORITHM = os.getenv("ALGORITHM", "HS256")
@@ -28,13 +27,16 @@ class NewsGetResponse(BaseModel):
 class NewsLikeResponse(BaseModel):
     total_likes: int | None
 
+
 class LikeRequest(BaseModel):
     email: str
 
+
 def encode_email(email: str) -> str:
     """Encodes the email to be safely stored in database."""
     return jwt.encode({"email": email}, SECRET_KEY, algorithm=ALGORITHM)
 
+
 def setup():
     router = APIRouter(prefix="/news", tags=["news"])
 

tests/test_news.py

@@ -288,7 +288,7 @@ async def test_news_integration(
 
 
 @pytest.mark.asyncio
-async def test_insert_news_likes_endpoint(
+async def test_news_likes_endpoint(
     session: AsyncSession,
     async_client: AsyncClient,
     community: Community,
@@ -312,63 +312,52 @@ async def test_insert_news_likes_endpoint(
     assert stored_news is not None
     assert stored_news.likes == 0
 
-    email = "like@test.com"
+    emails = ["like@test.com", "like2@test.com"]
 
+    # Add likes
     response = await async_client.post(
         f"/api/news/{stored_news.id}/like",
-        json={"email": email},
+        json={"email": emails[0]},
         headers=valid_auth_headers,
     )
     assert response.status_code == status.HTTP_200_OK
     statement = select(News).where(News.title == news_data["title"])
     result = await session.exec(statement)
     stored_news = result.first()
     assert stored_news.likes == 1
-    assert stored_news.user_email_list == f"['{encode_email(email)}']"
+    assert stored_news.user_email_list == f"['{encode_email(emails[0])}']"
 
-
-@pytest.mark.asyncio
-async def test_delete_news_likes_endpoint(
-    session: AsyncSession,
-    async_client: AsyncClient,
-    community: Community,
-    valid_auth_headers: Mapping[str, str],
-):
-    news_data = {
-        "title": "Test News",
-        "content": "Test news content.",
-        "category": "test_category",
-        "tags": "test_tag",
-        "source_url": "https://example.com/test-news",
-        "social_media_url": "https://test.com/test_news",
-    }
     response = await async_client.post(
-        "/api/news", json=news_data, headers=valid_auth_headers
+        f"/api/news/{stored_news.id}/like",
+        json={"email": emails[1]},
+        headers=valid_auth_headers,
     )
     assert response.status_code == status.HTTP_200_OK
     statement = select(News).where(News.title == news_data["title"])
     result = await session.exec(statement)
     stored_news = result.first()
-    assert stored_news is not None
-    assert stored_news.likes == 0
-
-    email = "like@test.com"
+    assert stored_news.likes == 2
+    assert (
+        stored_news.user_email_list
+        == f"['{encode_email(emails[0])}', '{encode_email(emails[1])}']"
+    )
 
-    response = await async_client.post(
+    # Remove likes
+    response = await async_client.delete(
         f"/api/news/{stored_news.id}/like",
-        json={"email": email},
+        params={"email": emails[0]},
         headers=valid_auth_headers,
     )
     assert response.status_code == status.HTTP_200_OK
     statement = select(News).where(News.title == news_data["title"])
     result = await session.exec(statement)
     stored_news = result.first()
     assert stored_news.likes == 1
-    assert stored_news.user_email_list == f"['{encode_email(email)}']"
+    assert stored_news.user_email_list == f"['{encode_email(emails[1])}']"
 
     response = await async_client.delete(
         f"/api/news/{stored_news.id}/like",
-        params={"email": email},
+        params={"email": emails[1]},
         headers=valid_auth_headers,
     )
     assert response.status_code == status.HTTP_200_OK