Fix post news endpoint

- update tests
- test integration with get

Author: arthur-mesquita

app/routers/news/routes.py

@@ -4,8 +4,9 @@
 from fastapi.params import Header
 from pydantic import BaseModel
 from routers.authentication import get_current_active_community
-from services.database.orm.news import get_news_by_query_params
+from services.database.orm.news import create_news, get_news_by_query_params
 
+from app.schemas import News
 from app.services.database.models import Community as DBCommunity
 
 
@@ -28,10 +29,22 @@ def setup():
         summary="News endpoint",
         description="Creates news and returns a confirmation message",
     )
-    async def post_news():
+    async def post_news(
+        request: Request,
+        current_community: Annotated[
+            DBCommunity, Depends(get_current_active_community)
+        ],
+        news: News,
+        user_email: str = Header(..., alias="user-email"),
+    ):
         """
         News endpoint that creates news and returns a confirmation message.
         """
+        news_dict = news.__dict__
+        news_dict["user_email"] = user_email
+        await create_news(
+            session=request.app.db_session_factory, news=news_dict
+        )
         return NewsPostResponse()
 
     @router.get(
@@ -47,7 +60,7 @@ async def get_news(
             DBCommunity, Depends(get_current_active_community)
         ],
         id: str | None = None,
-        user_email: str | None = Header(..., alias="user-email"),
+        user_email: str = Header(..., alias="user-email"),
         category: str | None = None,
         tags: str | None = None,
     ):

app/schemas.py

@@ -21,6 +21,16 @@ class CommunityInDB(Community):
     password: str
 
 
+class News(BaseModel):
+    title: str
+    content: str
+    category: str
+    tags: str | None = None
+    source_url: str
+    social_media_url: str | None = None
+    likes: int = 0
+
+
 class Token(BaseModel):
     access_token: str
     token_type: str

app/services/database/orm/news.py

@@ -5,6 +5,22 @@
 from sqlmodel.ext.asyncio.session import AsyncSession
 
 
+async def create_news(session: AsyncSession, news: dict) -> None:
+    _news = News(
+        title=news["title"],
+        content=news["content"],
+        category=news["category"],
+        user_email=news["user_email"],
+        source_url=news["source_url"],
+        tags=news["tags"] or "",
+        social_media_url=news["social_media_url"] or "",
+        likes=news["likes"],
+    )
+    session.add(_news)
+    await session.commit()
+    await session.refresh(_news)
+
+
 async def get_news_by_query_params(
     session: AsyncSession,
     email: Optional[str] = None,

tests/test_news.py

@@ -91,11 +91,56 @@ async def test_post_news_endpoint(
     async_client: AsyncClient, valid_auth_headers: Mapping[str, str]
 ):
     """Test the news endpoint returns correct status."""
-    response = await async_client.post("/api/news", headers=valid_auth_headers)
+    news_data = {
+        "title": "Test News",
+        "content": "Test news content.",
+        "category": "test_category",
+        "source_url": "https://example.com/test-news",
+    }
+    response = await async_client.post(
+        "/api/news", headers=valid_auth_headers, json=news_data
+    )
     assert response.status_code == status.HTTP_200_OK
     assert response.json() == {"status": "News Criada"}
 
 
+@pytest.mark.asyncio
+async def test_insert_news_via_post_news_endpoint(
+    session: AsyncSession,
+    async_client: AsyncClient,
+    community: Community,
+    valid_auth_headers: Mapping[str, str],
+):
+    news_data = {
+        "title": "Test News",
+        "content": "Test news content.",
+        "category": "test_category",
+        "tags": "test_tag",
+        "source_url": "https://example.com/test-news",
+        "social_media_url": "https://test.com/test_news",
+    }
+    response = await async_client.post(
+        "/api/news", json=news_data, headers=valid_auth_headers
+    )
+    assert response.status_code == status.HTTP_200_OK
+    statement = select(News).where(News.title == news_data["title"])
+    result = await session.exec(statement)
+    stored_news = result.first()
+    assert stored_news is not None
+    assert stored_news.title == news_data["title"]
+    assert stored_news.content == news_data["content"]
+    assert stored_news.category == news_data["category"]
+    assert stored_news.user_email == community.email
+    assert stored_news.source_url == news_data["source_url"]
+    assert stored_news.tags == news_data["tags"]
+    assert stored_news.social_media_url == news_data["social_media_url"]
+    assert stored_news.likes == 0
+    assert isinstance(stored_news.created_at, datetime)
+    assert isinstance(stored_news.updated_at, datetime)
+    assert stored_news.created_at <= datetime.now()
+    assert stored_news.updated_at >= stored_news.created_at
+
+
 @pytest.mark.asyncio
 async def test_get_news_endpoint(
     session: AsyncSession,
@@ -198,3 +243,43 @@ async def test_get_news_empty_result(
     assert response.status_code == status.HTTP_200_OK
     assert "news_list" in data
     assert data["news_list"] == []
+
+
+@pytest.mark.asyncio
+async def test_news_integration(
+    session: AsyncSession,
+    async_client: AsyncClient,
+    community: Community,
+    valid_auth_headers: Mapping[str, str],
+):
+    news_data = {
+        "title": "Test News",
+        "content": "Test news content.",
+        "category": "test_category",
+        "tags": "test_tag",
+        "source_url": "https://example.com/test-news",
+        "social_media_url": "https://test.com/test_news",
+    }
+    post_response = await async_client.post(
+        "/api/news", json=news_data, headers=valid_auth_headers
+    )
+    assert post_response.status_code == status.HTTP_200_OK
+    get_response = await async_client.get(
+        "/api/news",
+        headers=valid_auth_headers,
+    )
+    data = get_response.json()
+    assert get_response.status_code == status.HTTP_200_OK
+    assert "news_list" in data
+    assert len(data["news_list"]) == 1
+    assert data["news_list"][0]["title"] == news_data["title"]
+    assert data["news_list"][0]["content"] == news_data["content"]
+    assert data["news_list"][0]["category"] == news_data["category"]
+    assert data["news_list"][0]["user_email"] == community.email
+    assert data["news_list"][0]["source_url"] == news_data["source_url"]
+    assert data["news_list"][0]["tags"] == news_data["tags"]
+    assert (
+        data["news_list"][0]["social_media_url"]
+        == news_data["social_media_url"]
+    )
+    assert data["news_list"][0]["likes"] == 0