feat: Blog Delete API Endpoint [Issue #2]

Author: Pythonian

api/v1/routes/blog.py

@@ -163,15 +163,54 @@ async def read_blog(
             status_code=status.HTTP_500_INTERNAL_SERVER_ERROR,
             detail="Database error occurred.",
         )
-    except ValueError as e:
-        logger.error(f"Invalid blog post ID '{id}': {e}")
+    except Exception as e:
+        logger.error(f"Unexpected error occurred: {e}")
+        raise HTTPException(
+            status_code=status.HTTP_500_INTERNAL_SERVER_ERROR,
+            detail="Unexpected error occurred.",
+        )
+
+
+@blog.delete(
+    "/{id}",
+    status_code=status.HTTP_204_NO_CONTENT,
+)
+async def delete_blog(
+    id: int,
+    db: Session = Depends(get_db),
+) -> None:
+    try:
+        blog_to_delete = (
+            db.query(Blog)
+            .filter(
+                Blog.id == id,
+                not_(Blog.is_deleted),
+            )
+            .first()
+        )
+        if not blog_to_delete:
+            logger.warning(f"Blog post with ID '{id}' not found.")
+            raise HTTPException(
+                status_code=status.HTTP_404_NOT_FOUND,
+                detail="Blog post with given id not found.",
+            )
+
+        blog_to_delete.is_deleted = True
+        db.commit()
+        logger.info(f"Blog post '{blog_to_delete.title}' deleted successfully.")
+
+    except SQLAlchemyError as e:
+        logger.error(f"Database error occurred: {e}")
+        db.rollback()
         raise HTTPException(
-            status_code=status.HTTP_400_BAD_REQUEST,
-            detail="Invalid blog post ID.",
+            status_code=status.HTTP_500_INTERNAL_SERVER_ERROR,
+            detail="Database error occurred.",
         )
+
     except Exception as e:
         logger.error(f"Unexpected error occurred: {e}")
+        db.rollback()
         raise HTTPException(
             status_code=status.HTTP_500_INTERNAL_SERVER_ERROR,
-            detail="Unexpected error occurred.",
+            detail="Internal server error.",
         )

tests/v1/blog/test_create_blog.py

@@ -108,21 +108,17 @@ def test_create_blog_internal_server_error(db_session_mock):
     assert response.json()["detail"] == "Internal server error."
 
 
-def test_create_blog_invalid_data(db_session_mock):
+def test_create_blog_invalid_data():
     """Sends invalid data (e.g., empty title) and checks for validation errors."""
     invalid_blog_data = {
-        "title": "",  # Title is required and cannot be empty
+        "title": "",
         "excerpt": "A summary of the blog post...",
         "content": "The content of the blog post...",
         "image_url": "image-url-link",
     }
 
     response = client.post("/api/v1/blogs", json=invalid_blog_data)
-
-    # Unprocessable Entity (validation error)
     assert response.status_code == 422
-    response_data = response.json()
-    assert "detail" in response_data
 
 
 def test_create_blog_boundary_testing(db_session_mock):

tests/v1/blog/test_delete_blog.py

@@ -0,0 +1,49 @@
+from datetime import datetime
+from unittest.mock import MagicMock
+
+import pytest
+from fastapi.testclient import TestClient
+
+from api.db.database import get_db
+from api.v1.models.blog import Blog
+from main import app
+
+client = TestClient(app)
+
+
+@pytest.fixture
+def db_session_mock():
+    return MagicMock()
+
+
+@pytest.fixture(autouse=True)
+def override_get_db(db_session_mock):
+    app.dependency_overrides[get_db] = lambda: db_session_mock
+    yield
+    app.dependency_overrides[get_db] = None
+
+
+def test_successful_soft_delete_blog_post(db_session_mock):
+    blog = Blog(
+        id=1,
+        title="Test Blog Post",
+        excerpt="This is a test excerpt",
+        content="This is the content of the test blog post",
+        image_url="http://example.com/image.png",
+        created_at=datetime(2024, 7, 22, 12, 0, 0),
+        updated_at=datetime(2024, 7, 22, 12, 0, 0),
+        is_deleted=False,
+    )
+
+    db_session_mock.query().filter().first.return_value = blog
+
+    response = client.delete("/api/v1/blogs/1")
+
+    assert response.status_code == 204
+    db_session_mock.commit.assert_called_once()
+
+
+def test_delete_invalid_blog_id(db_session_mock):
+    response = client.delete("/api/v1/blogs/abc")
+
+    assert response.status_code == 422

tests/v1/blog/test_read_blog.py

@@ -53,7 +53,3 @@ def test_invalid_blog_post_id():
     response = client.get("/api/v1/blogs/abc")
 
     assert response.status_code == 422
-    data = response.json()
-    assert "detail" in data
-    assert isinstance(data["detail"], list)
-    assert any("msg" in error for error in data["detail"])