Skip to content

Commit 172703e

Browse files
veksenclaude
andcommitted
fix: lower Node.js minimum to >=20.0.0 for drizzle, typeorm, and mikroorm
The only Node 24-specific API used was the `name` option on AsyncLocalStorage, which is a debugging aid with no runtime impact. Removing it allows all three packages to support Node 20+. - Remove `{ name }` option from AsyncLocalStorage constructor - Lower @types/node from ^24.5.2 to ^20.19.34 - Change engines.node from >=24.8.0 to >=20.0.0 - Bump patch versions (drizzle 0.1.1, typeorm 0.0.2, mikroorm 0.0.2) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
1 parent dfd1f51 commit 172703e

6 files changed

Lines changed: 12 additions & 18 deletions

File tree

nodejs/sqlcommenter-nodejs/packages/sqlcommenter-drizzle/package.json

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@query-doctor/sqlcommenter-drizzle",
3-
"version": "0.1.0",
3+
"version": "0.1.1",
44
"description": "SQLCommenter patch for drizzle-orm",
55
"main": "dist/cjs/index.js",
66
"type": "module",
@@ -32,7 +32,7 @@
3232
},
3333
"devDependencies": {
3434
"@electric-sql/pglite": "^0.3.10",
35-
"@types/node": "^24.5.2",
35+
"@types/node": "^20.19.34",
3636
"hono": "^4.9.8",
3737
"postgres": "^3.4.7",
3838
"rewiremock": "^3.14.3",
@@ -47,7 +47,7 @@
4747
"drizzle-orm": ">=0.35.0"
4848
},
4949
"engines": {
50-
"node": ">=24.8.0"
50+
"node": ">=20.0.0"
5151
},
5252
"scripts": {
5353
"test": "node --import=tsx --test test/**/*.spec.ts",
Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,4 @@
11
import { AsyncLocalStorage } from "node:async_hooks";
22
import type { RequestContext } from "./request-context.js";
33

4-
export const als = new AsyncLocalStorage<RequestContext>({
5-
name: "request-context",
6-
});
4+
export const als = new AsyncLocalStorage<RequestContext>();

nodejs/sqlcommenter-nodejs/packages/sqlcommenter-mikroorm/package.json

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@query-doctor/sqlcommenter-mikroorm",
3-
"version": "0.0.1",
3+
"version": "0.0.2",
44
"description": "SQLCommenter patch for MikroORM",
55
"main": "dist/cjs/index.js",
66
"type": "module",
@@ -32,7 +32,7 @@
3232
},
3333
"devDependencies": {
3434
"@mikro-orm/better-sqlite": "^6.6.7",
35-
"@types/node": "^24.5.2",
35+
"@types/node": "^20.19.34",
3636
"better-sqlite3": "^12.6.2",
3737
"tsx": "^4.20.5",
3838
"typescript": "^5.9.3"
@@ -45,7 +45,7 @@
4545
"@opentelemetry/core": ">=1.0.0"
4646
},
4747
"engines": {
48-
"node": ">=24.8.0"
48+
"node": ">=20.0.0"
4949
},
5050
"scripts": {
5151
"test": "node --import=tsx --test test/**/*.spec.ts",
Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,4 @@
11
import { AsyncLocalStorage } from "node:async_hooks";
22
import type { RequestContext } from "./request-context.js";
33

4-
export const als = new AsyncLocalStorage<RequestContext>({
5-
name: "request-context",
6-
});
4+
export const als = new AsyncLocalStorage<RequestContext>();

nodejs/sqlcommenter-nodejs/packages/sqlcommenter-typeorm/package.json

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@query-doctor/sqlcommenter-typeorm",
3-
"version": "0.0.1",
3+
"version": "0.0.2",
44
"description": "SQLCommenter patch for TypeORM",
55
"main": "dist/cjs/index.js",
66
"type": "module",
@@ -32,7 +32,7 @@
3232
}
3333
},
3434
"devDependencies": {
35-
"@types/node": "^24.5.2",
35+
"@types/node": "^20.19.34",
3636
"reflect-metadata": "^0.2.2",
3737
"sql.js": "^1.12.0",
3838
"tsx": "^4.20.5",
@@ -46,7 +46,7 @@
4646
"typeorm": ">=0.3.0"
4747
},
4848
"engines": {
49-
"node": ">=24.8.0"
49+
"node": ">=20.0.0"
5050
},
5151
"scripts": {
5252
"test": "node --import=tsx --test test/**/*.spec.ts",
Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,4 @@
11
import { AsyncLocalStorage } from "node:async_hooks";
22
import type { RequestContext } from "./request-context.js";
33

4-
export const als = new AsyncLocalStorage<RequestContext>({
5-
name: "request-context",
6-
});
4+
export const als = new AsyncLocalStorage<RequestContext>();

0 commit comments

Comments
 (0)