wip: migrate hub

Author: justinmerrell

.github/workflows/pylint.yml

@@ -26,4 +26,4 @@ jobs:
         pylint `ls -r|grep .py$|xargs` --disable=import-error,E1101 || pylint-exit --error-fail --warn-fail --convention-fail $?
         pylint openpod `ls -r|grep .py$|xargs` --disable=import-error,E1101 || pylint-exit --error-fail --warn-fail --convention-fail $?
 
-        pylint tests `ls -r|grep .py$|xargs` --disable=import-error,E1101 || pylint-exit --error-fail --warn-fail --convention-fail $?
+        pylint tests `ls -r|grep .py$|xargs` --disable=import-error,E1101,R0801 || pylint-exit --error-fail --warn-fail --convention-fail $?

openpod/modules/rec_mqtt.py

@@ -58,7 +58,7 @@ def on_message(client, userdata, message):
 
         if 0 < int(message.payload) <= 256:
             mqtt_actions[int(message.payload)]()
-            return
+            return True
 
     except ValueError as err:
         mqtt_log.info("Not a single number command. Error: %s", err)
@@ -77,7 +77,7 @@ def on_message(client, userdata, message):
 
         if look_up_responce == 1:
             rec_xbee.transmit(node_mac.group(1), f"{node_command.group(1)}")
-            return
+            return True
 
     except IndexError as err:
         mqtt_log.error("Unable to extract MAC with the following error: %s", err)

tests/modules/test_lookup.py

@@ -89,7 +89,7 @@ def test_count_matching_mac(self):
 
             mock_open.assert_called()
 
-class TestLookUpAccessRequest(unittest.TestCase):
+class TestLookUpAccessRequest(unittest.TestCase):           # pylint: disable=R0904
     '''Access Request Tests'''
 
     def setUp(self):

tests/modules/test_mqtt.py

@@ -7,7 +7,9 @@
 from modules import rec_mqtt
 
 
-class DummyMessage:
+class DummyMessage:                                 # pylint: disable=R0903
+    '''Creating a mock response'''
+
     def __init__(self, command):
         self.payload=command
 
@@ -21,7 +23,9 @@ def test_function_calls(self):
         Checks that the function calls are correct.
         '''
         with patch('modules.rec_mqtt.rec_api.link_hub') as mock_link:
-            rec_mqtt.on_message('test_client', None, DummyMessage('170'))
+            self.assertTrue(
+                rec_mqtt.on_message('test_client', None, DummyMessage('170'))
+            )
             mock_link.assert_called()
 
         with patch('modules.rec_mqtt.rec_api.pull_data_dump') as mock_pull: