Skip to content

Commit d5e07db

Browse files
authored
feat: add sdk_endpoint parameter to Provider class (#2682)
Add sdkEndpoint support to Provider CR settings, allowing users to specify the vCenter SDK endpoint type (e.g., vcenter or esxi) for vSphere providers. The settings dict is now built conditionally so only provided settings are included in the CR spec. Ref: https://github.com/kubev2v/forklift/blob/main/pkg/apis/forklift/v1beta1/provider.go#L73
1 parent 5b13fa7 commit d5e07db

1 file changed

Lines changed: 9 additions & 1 deletion

File tree

ocp_resources/provider.py

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@ def __init__(
1717
secret_name: str | None = None,
1818
secret_namespace: str | None = None,
1919
vddk_init_image: str | None = None,
20+
sdk_endpoint: str | None = None,
2021
**kwargs: Any,
2122
):
2223
super().__init__(**kwargs)
@@ -25,10 +26,17 @@ def __init__(
2526
self.secret_name = secret_name
2627
self.secret_namespace = secret_namespace
2728
self.vddk_init_image = vddk_init_image
29+
self.sdk_endpoint = sdk_endpoint
2830

2931
def to_dict(self) -> None:
3032
super().to_dict()
3133
if not self.kind_dict and not self.yaml_file:
34+
settings: dict[str, str] = {}
35+
if self.vddk_init_image:
36+
settings["vddkInitImage"] = self.vddk_init_image
37+
if self.sdk_endpoint:
38+
settings["sdkEndpoint"] = self.sdk_endpoint
39+
3240
self.res.update({
3341
"spec": {
3442
"type": self.provider_type,
@@ -37,6 +45,6 @@ def to_dict(self) -> None:
3745
"name": self.secret_name,
3846
"namespace": self.secret_namespace,
3947
},
40-
"settings": {"vddkInitImage": self.vddk_init_image},
48+
"settings": settings,
4149
}
4250
})

0 commit comments

Comments
 (0)