Allocate device_ptr memory only for sizes > 0 on all backends (fixing test errors on CPUs).

Author: breyerml

src/plssvm/backends/CUDA/detail/device_ptr.cu

@@ -40,11 +40,11 @@ device_ptr<T>::device_ptr(const plssvm::shape shape, const plssvm::shape padding
     if (queue_ < 0 || queue_ >= get_device_count()) {
         throw backend_exception{ fmt::format("Illegal device ID! Must be in range: [0, {}) but is {}.", get_device_count(), queue_) };
     }
-    detail::set_device(queue_);
-    PLSSVM_CUDA_ERROR_CHECK(cudaMalloc(&data_, this->size_padded() * sizeof(value_type)))
 
     // only non-empty pointers must be memset in the constructor
     if (this->size_padded() != std::size_t{ 0 }) {
+        detail::set_device(queue_);
+        PLSSVM_CUDA_ERROR_CHECK(cudaMalloc(&data_, this->size_padded() * sizeof(value_type)))
         this->memset(0);
     }
 }

src/plssvm/backends/HIP/detail/device_ptr.hip

@@ -42,11 +42,11 @@ device_ptr<T>::device_ptr(const plssvm::shape shape, const plssvm::shape padding
     if (queue_ < 0 || queue_ >= get_device_count()) {
         throw backend_exception{ fmt::format("Illegal device ID! Must be in range: [0, {}) but is {}.", get_device_count(), queue_) };
     }
-    detail::set_device(queue_);
-    PLSSVM_HIP_ERROR_CHECK(hipMalloc(&data_, this->size_padded() * sizeof(value_type)))
 
     // only non-empty pointers must be memset in the constructor
     if (this->size_padded() != std::size_t{ 0 }) {
+        detail::set_device(queue_);
+        PLSSVM_HIP_ERROR_CHECK(hipMalloc(&data_, this->size_padded() * sizeof(value_type)))
         this->memset(0);
     }
 }

src/plssvm/backends/SYCL/AdaptiveCpp/detail/device_ptr.cpp

@@ -38,10 +38,9 @@ device_ptr<T>::device_ptr(const plssvm::shape shape, const queue &q) :
 template <typename T>
 device_ptr<T>::device_ptr(const plssvm::shape shape, const plssvm::shape padding, const queue &q) :
     base_type{ shape, padding, q } {
-    data_ = ::sycl::malloc_device<value_type>(this->size_padded(), queue_.impl->sycl_queue);
-
     // only non-empty pointers must be memset in the constructor
     if (this->size_padded() != std::size_t{ 0 }) {
+        data_ = ::sycl::malloc_device<value_type>(this->size_padded(), queue_.impl->sycl_queue);
         this->memset(0);
     }
 }

src/plssvm/backends/SYCL/DPCPP/detail/device_ptr.cpp

@@ -39,10 +39,9 @@ device_ptr<T>::device_ptr(const plssvm::shape shape, const queue &q) :
 template <typename T>
 device_ptr<T>::device_ptr(const plssvm::shape shape, plssvm::shape padding, const queue &q) :
     base_type{ shape, padding, q } {
-    data_ = ::sycl::malloc_device<value_type>(this->size_padded(), queue_.impl->sycl_queue);
-
     // only non-empty pointers must be memset in the constructor
     if (this->size_padded() != std::size_t{ 0 }) {
+        data_ = ::sycl::malloc_device<value_type>(this->size_padded(), queue_.impl->sycl_queue);
         this->memset(0);
     }
 }