fix: ⚡ Update Orchestrator and EdgeConnect login functions to account for timeout error when trying to call login to unreachable destination

zachcamara-hpe · zachcamara-hpe · commit 83ec748ba150 · 2022-10-04T08:57:48.000-04:00
diff --git a/pyedgeconnect/ecos/_login.py b/pyedgeconnect/ecos/_login.py
@@ -35,7 +35,7 @@ def login(
             return_type="full_response",
         )
 
-        if response.status_code == 200:
+        if response is not None and response.status_code == 200:
             # get and set X-XSRF-TOKEN
             for cookie in response.cookies:
                 if cookie.name == "edgeosCsrfToken":
@@ -59,7 +59,7 @@ def login(
             return False
 
     except Exception as ex:
-        self.logger.error("login error: {}".format(type(ex)))
+        self.logger.error("login error: {}".format(ex))
         return False
 
 
diff --git a/pyedgeconnect/orch/_login.py b/pyedgeconnect/orch/_login.py
@@ -69,7 +69,7 @@ def login(
         return_type="full_response",
     )
 
-    if response.status_code == 200:
+    if response is not None and response.status_code == 200:
         # get and set X-XSRF-TOKEN
         for cookie in response.cookies:
             if cookie.name == "orchCsrfToken":

Original file line number	Diff line number	Diff line change
`@@ -69,7 +69,7 @@ def login(`
`69`	`69`	`return_type="full_response",`
`70`	`70`	`)`
`71`	`71`
`72`		`- if response.status_code == 200:`
	`72`	`+ if response is not None and response.status_code == 200:`
`73`	`73`	`# get and set X-XSRF-TOKEN`
`74`	`74`	`for cookie in response.cookies:`
`75`	`75`	`if cookie.name == "orchCsrfToken":`