Skip to content

Commit e52c049

Browse files
Merge branch 'may22bugfixes' into development
2 parents 77e9c4e + 726011b commit e52c049

3 files changed

Lines changed: 13 additions & 12 deletions

File tree

pyedgeconnect/orch/_rbac_appliance_access_group.py

Lines changed: 10 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -36,10 +36,13 @@ def get_all_appliance_access_groups(
3636
def update_appliance_access_group(
3737
self,
3838
appliance_access_group_name: str,
39-
appliance_groups: list[str] = None,
40-
appliance_regions: list[str] = None,
39+
appliance_groups: list[str],
40+
appliance_regions: list[str],
4141
) -> bool:
42-
"""Create or update appliance access gropu / asset
42+
"""Create or update appliance access group / asset.
43+
Both list of ``appliance_groups`` and ``appliance_regions``
44+
must be specified, if no group or region is desired, provide
45+
a blank list as input.
4346
4447
.. list-table::
4548
:header-rows: 1
@@ -55,11 +58,11 @@ def update_appliance_access_group(
5558
appliance access group to create or update
5659
:type appliance_access_group_name: str
5760
:param appliance_groups: List of appliance group id's the access
58-
group will allow access to, defaults to None
59-
:type appliance_groups: list[str], optional
61+
group will allow access to
62+
:type appliance_groups: list[str]
6063
:param appliance_regions: List of region id's the access group will
61-
allow access to, defaults to None
62-
:type appliance_regions: list[str], optional
64+
allow access to
65+
:type appliance_regions: list[str]
6366
:return: Returns True/False based on successful call
6467
:rtype: bool
6568
"""

pyedgeconnect/orch/_timeseries_stats.py

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -137,7 +137,7 @@ def get_timeseries_stats_tunnel_single_appliance(
137137
"""
138138
path = (
139139
"/stats/timeseries/tunnel/"
140-
+ "{}?startTime={}&endTime={}&granularity={}&tunnel_name={}".format(
140+
+ "{}?startTime={}&endTime={}&granularity={}&tunnelName={}".format(
141141
ne_pk, start_time, end_time, granularity, tunnel_name
142142
)
143143
)
@@ -2347,9 +2347,7 @@ def get_timeseries_stats_security_policy_single_appliance(
23472347
"""
23482348
path = (
23492349
"/stats/timeseries/securityPolicy/"
2350-
+ "{}?startTime={}&endTime={}".format(
2351-
ne_pk, start_time, end_time
2352-
)
2350+
+ "{}?startTime={}&endTime={}".format(ne_pk, start_time, end_time)
23532351
+ "&granularity={}&fromZone={}&toZone={}".format(
23542352
granularity, from_zone, to_zone
23552353
)

pyedgeconnect/orch/_user.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ def get_all_users(
4242
* keyword **salt** (`str`): Usually left blank
4343
:rtype: list
4444
"""
45-
return self._post("/users")
45+
return self._get("/users")
4646

4747

4848
def get_user(

0 commit comments

Comments
 (0)