avoid modifying collection

barfeous · barfeous · commit eb0f02577290 · 2024-02-12T13:28:54.000-06:00
diff --git a/src/TensorFlowNET.Core/Training/Saving/SavedModel/AugmentedGraphView.cs b/src/TensorFlowNET.Core/Training/Saving/SavedModel/AugmentedGraphView.cs
@@ -88,7 +88,7 @@ private ConcreteFunction maybe_uncache_variable_captures(ConcreteFunction concre
 
     public override (IList<Trackable>, IDictionary<Trackable, IEnumerable<TrackableReference>>) breadth_first_traversal()
     {
-        Trackable get_merged_trackable(Trackable x)
+        void merged_trackable(Trackable x)
         {
             // TODO: complete it with new definitions `Asset` and `TrackableConstant`.
             return x;
@@ -100,7 +100,7 @@ Trackable get_merged_trackable(Trackable x)
             // skip the deletion of cache (maybe do it later).
             foreach(var pair in _children_cache[obj])
             {
-                _children_cache[obj][pair.Key] = get_merged_trackable(pair.Value);
+                merged_trackable(pair.Value);
             }
         }
 

Original file line number	Diff line number	Diff line change
`@@ -88,7 +88,7 @@ private ConcreteFunction maybe_uncache_variable_captures(ConcreteFunction concre`
`88`	`88`
`89`	`89`	`public override (IList<Trackable>, IDictionary<Trackable, IEnumerable<TrackableReference>>) breadth_first_traversal()`
`90`	`90`	`{`
`91`		`- Trackable get_merged_trackable(Trackable x)`
	`91`	`+ void merged_trackable(Trackable x)`
`92`	`92`	`{`
`93`	`93`	// TODO: complete it with new definitions `Asset` and `TrackableConstant`.
`94`	`94`	`return x;`
`@@ -100,7 +100,7 @@ Trackable get_merged_trackable(Trackable x)`
`100`	`100`	`// skip the deletion of cache (maybe do it later).`
`101`	`101`	`foreach(var pair in _children_cache[obj])`
`102`	`102`	`{`
`103`		`- _children_cache[obj][pair.Key] = get_merged_trackable(pair.Value);`
	`103`	`+ merged_trackable(pair.Value);`
`104`	`104`	`}`
`105`	`105`	`}`
`106`	`106`