Skip to content

tech-debt: Add regression tests for PRs #474-476, #480-482, #496-497, #501-502 #485

@SebTardif

Description

@SebTardif

Summary

Six PRs from Rounds 63-64 fix real bugs but have no regression tests. Each fix is a one-line match arm addition, and the bugs are in compiler internals that require specific type-system states to trigger. Tests should verify the fix prevents regression.

PRs needing regression tests

PR Issue Bug Test strategy
#474 #471 ARM VFP uses triple suffix, misses Apple hard-float tests/assembly/ or tests/codegen/ with ARM target
#475 #472 struct_lockstep_tails_raw missing ty::Pat tests/ui/ with pattern types feature
#476 #469 ReverseMapper missing CoroutineClosure + fold_const no recurse tests/ui/ with async closures + opaque types
#480 #479 maybe_drop_guard missing CoroutineClosure tests/ui/ with async closure drop guards
#481 #477 simplify_nounwind_call missing CoroutineClosure + Error tests/mir-opt/ with async closure MIR
#482 #478 describe_field_from_ty missing CoroutineClosure tests/ui/ with async closure borrow error diagnostic

Context

These are all CoroutineClosure TyKind variant gaps (except #474 which is ARM ABI, and #475 which is ty::Pat). Async closures are stable since Rust 1.85, so test cases should compile on stable.

Acceptance criteria

  • Each PR has at least one regression test that fails without the fix and passes with it
  • Tests follow the patterns in rust-contrib SKILL.md "Test Writing Patterns by Area"

Metadata

Metadata

Assignees

No one assigned

    Labels

    A-mirMIR building and transformsA-type-systemType systemP-mediumMedium impact: affects specific usage patternsbugSomething isn't working

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions