Skip to content

avoid double negation ${PROJECT_NAME}_INSTALL_NO_DEVELOPMENT, switch to CMake option #72

Description

@ferdymercury

As pointed out by @lassoan in commontk/qRestAPI#28 (review)

It would be great to avoid the double negation ${PROJECT_NAME}_INSTALL_NO_DEVELOPMENT and use a more modern CMake option. The old variable could be kept for backward compatibility.

so we could fix this negative naming and lack of option defintion in vtkAddon, before it spreads to too many places.

The main historical reason Slicer-family projects used the if(NOT DEFINED ...) pattern instead of option() is that before CMake 3.13, option() would clobber a normal variable set by a parent project before add_subdirectory(). With CMP0077 set to NEW, option() honors a pre-set normal variable and becomes strictly better.

This is to match the reorganization of CMake in commontk/qRestAPI#28 by @RafaelPalomar

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions