From 8a6ddb5d7bd50d1f2163e602fc19711d1fb670a6 Mon Sep 17 00:00:00 2001 From: HRS Date: Sun, 11 Jan 2026 13:44:18 +0100 Subject: [PATCH 1/3] Commented out coreaudio warning regarding buffer underflow --- deps/mpg123/src/output/coreaudio.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/deps/mpg123/src/output/coreaudio.c b/deps/mpg123/src/output/coreaudio.c index c9db31e..af241aa 100644 --- a/deps/mpg123/src/output/coreaudio.c +++ b/deps/mpg123/src/output/coreaudio.c @@ -78,7 +78,8 @@ static OSStatus playProc(AudioConverterRef inAudioConverter, /* Only play if we have data left */ if ( sfifo_used( &ca->fifo ) < (int)wanted ) { if(!ca->decode_done) { - warning("Didn't have any audio data in callback (buffer underflow)"); + // Commented out below warning because it floods stdout + // warning("Didn't have any audio data in callback (buffer underflow)"); return -1; } wanted = sfifo_used( &ca->fifo ); From 8a20f2dd5d781d561486a5ee919c86e9bcbcf796 Mon Sep 17 00:00:00 2001 From: HRS Date: Sun, 11 Jan 2026 13:50:46 +0100 Subject: [PATCH 2/3] Add test summary to use as status check --- .github/workflows/test.yml | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index cd60f96..a157509 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -52,3 +52,19 @@ jobs: - name: Run tests run: npm test + + # Summary job that all matrix jobs must pass + # Used as the required status check in branch protection + test-summary: + name: Test Summary + runs-on: ubuntu-latest + needs: build + if: always() + steps: + - name: Check build matrix status + run: | + if [ "${{ needs.build.result }}" != "success" ]; then + echo "One or more build jobs failed" + exit 1 + fi + echo "All build jobs passed successfully" From 26f0751ce1bfb56a6ba2ffcc88e8e2bb1423e5cb Mon Sep 17 00:00:00 2001 From: HRS Date: Sun, 11 Jan 2026 13:59:48 +0100 Subject: [PATCH 3/3] Don't run tests on every push --- .github/workflows/test.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index a157509..4524250 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -1,6 +1,6 @@ name: Node CI -on: [push, pull_request] +on: pull_request jobs: build: