Skip to content

psalm check ParamNameMismatch error #194

Description

@GradPV

installed version: "socialconnect/auth": "3.5.0"

\SocialConnect\Provider\AbstractBaseProvider::getAccessTokenByRequestParameters has array $requestParameters signature
but \SocialConnect\OAuth2\AbstractProvider::getAccessTokenByRequestParameters has array $parameters signature

i extended \SocialConnect\OAuth2\AbstractProvider class and implemented getAccessTokenByRequestParameters and no matter what signature i'll choose, psalm will give me the error

ERROR: ParamNameMismatch - Argument 1 of Google::getAccessTokenByRequestParameters has wrong name $parameters, expecting $requestParameters as defined by SocialConnect\Provider\AbstractBaseProvider::getAccessTokenByRequestParameters (see https://psalm.dev/230)
    public function getAccessTokenByRequestParameters(array $parameters)

or

ERROR: ParamNameMismatch - Argument 1 of Google::getAccessTokenByRequestParameters has wrong name $requestParameters, expecting $parameters as defined by SocialConnect\OAuth2\AbstractProvider::getAccessTokenByRequestParameters (see https://psalm.dev/230)
    public function getAccessTokenByRequestParameters(array $requestParameters)

So as I can see it would be better to change \SocialConnect\OAuth2\AbstractProvider::getAccessTokenByRequestParameters to array $requestParameters as in parent class

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions