fix: Fixed concrete classes of a different type added to type database after a generic unity-object class is removed

Author: SolidAlloy

Editor/GenericTypesAnalyzer/DictInitializer.cs

@@ -94,21 +94,10 @@ private static Dictionary<Type[], Type> CreateConcreteClassesDict(GenericTypeInf
                 if (!TryGetConcreteClassType(genericTypeInfo, concreteClass, out Type value))
                     continue;
 
-                // BUG: This somehow happened once. It started throwing exception after I commented out a generic class not related to genericTypeInfo nor the concrete class in question. 
-                // Would be good to have the steps to reproduce.
-                if (value.BaseType?.GetGenericTypeDefinition() != genericTypeInfo.Type)
-                {
-                    Debug.LogWarning($"The concrete class for type {value.BaseType} was added to the generic type {genericTypeInfo.Type.Name}. " +
-                                     "This shouldn't happen. If you have steps to reproduce the bug, please report it.");
-                    
-                    GenerationDatabase<TObject>.RemoveConcreteClass(genericTypeInfo, concreteClass);
-                    continue;
-                }
-             
                 var key = GetConcreteClassArguments(concreteClass);
                 concreteClassesDict.Add(key, value);
             }
-            
+
             return concreteClassesDict;
         }
 

Editor/GenericTypesAnalyzer/GenericTypesAnalyzer.cs

@@ -87,12 +87,8 @@ private static void AddMissingConcreteClassesToDatabase<TObject>()
 
             // Have to use the extension method explicitly to avoid ambiguous reference error between SolidUtilities.ToHashSet and NetStandard 2.1 Enumerable.ToHashSet
             var registeredGuids = EnumerableExtensions.ToHashSet(GenerationDatabase<TObject>.GenericTypeArguments.Values
-                    .Aggregate((allConcreteClasses, thisClasses) =>
-                    {
-                        allConcreteClasses.AddRange(thisClasses);
-                        return allConcreteClasses;
-                    })
-                    .Select(concreteClass => concreteClass.AssemblyGUID));
+                .SelectMany(classesList => classesList)
+                .Select(concreteClass => concreteClass.AssemblyGUID));
 
             // If there are assemblies that exist in the folder but are missing from the database, add them to the database.
             foreach (string guid in guids)
@@ -115,7 +111,7 @@ private static void AddMissingConcreteClassesToDatabase<TObject>()
 
                 // Happens when the generic script file was removed but the concrete class still exists.
                 if (genericType == null)
-                    return;
+                    continue;
 
                 Type genericTypeWithoutArgs = genericType.GetGenericTypeDefinition();
                 Type[] genericArgs = genericType.GenericTypeArguments;

Editor/OnScriptsReloadActionsRunner.cs

@@ -17,7 +17,6 @@ private static void OnScriptsReload()
                 return;
             }
 
-
             // 1. GenericTypesAnalyzer finds a new generic MonoBehaviour and generates a DLL.
             // 2. Scripts are recompiled because of the DLL addition.
             // 3. This event is fired before GenericTypesAnalyzer is called again, and sets the custom icon.