SLVSCODE-1655 Remove client-side on-demand download for CFamily and OmniSharp analyzers

Author: nquinquenel

build-sonarlint/common.mjs

@@ -5,8 +5,8 @@
  * Licensed under the LGPLv3 License. See LICENSE.txt in the project root for license information.
  * ------------------------------------------------------------------------------------------ */
 'use strict';
-  import { createVSIX } from '@vscode/vsce';
-import { clean, cleanOmnisharpDir } from './fsUtils.mjs';
+import { createVSIX } from '@vscode/vsce';
+import { clean } from './fsUtils.mjs';
 import { info } from 'fancy-log';
 import downloadJre from './jreDownload.mjs';
 import cycloneDx from './sbomGeneration.mjs';
@@ -15,12 +15,7 @@ import { deployBuildInfo, deployVsixWithPattern } from './deployUtils.mjs';
 import populateBuildNumber from './populateBuildNumber.mjs';
 import signVsix from './sign.mjs';
 import _default from './constants.mjs';
-import {
-  downloadOmnisharpAllPlatformDistributions,
-  downloadAndExtractOmnisharp,
-  omnisharpPlatformMapping
-} from './omnisharpDownload.mjs';
-const { TARGETED_PLATFORMS, LATEST_JRE, OMNISHARP_VERSION } = _default;
+const { TARGETED_PLATFORMS, LATEST_JRE } = _default;
 
 export async function deployUniversal() {
   commonPreBuildTasks();
@@ -37,7 +32,6 @@ export async function deployAllMicrosoft() {
 }
 
 async function buildUniversal() {
-  await downloadOmnisharpAllPlatformDistributions(OMNISHARP_VERSION);
   await createVSIX();
 }
 
@@ -51,10 +45,7 @@ async function buildTargeted() {
 
 async function buildForPlatform(platform) {
   await downloadJre(platform, LATEST_JRE);
-  await downloadAndExtractOmnisharp(OMNISHARP_VERSION, omnisharpPlatformMapping[platform]);
-  await downloadAndExtractOmnisharp(OMNISHARP_VERSION, 'net6.0');
   await createVSIX({ target: platform });
-  cleanOmnisharpDir();
 }
 
 function commonPreBuildTasks() {

build-sonarlint/constants.mjs

@@ -17,11 +17,6 @@ Object.defineProperty(constants, 'LATEST_JRE', {
   writable: false
 });
 
-Object.defineProperty(constants, 'OMNISHARP_VERSION', {
-  value: '1.39.15',
-  writable: false
-});
-
 Object.defineProperty(constants, 'TARGETED_PLATFORMS', {
   value: ['win32-x64', 'linux-x64', 'darwin-x64', 'darwin-arm64'],
   writable: false

build-sonarlint/deployAllMarketplaces.mjs

@@ -9,15 +9,14 @@ import { executeWithDurationLog, deployAllMicrosoft } from './common.mjs';
 import { deployAllOpenVSX } from './deployAllOpenVSX.mjs';
 import { deployBuildInfo, collectArtifactInfo } from './deployUtils.mjs';
 
-// Deploy Microsoft marketplace variants (with OmniSharp in all packages)
 await executeWithDurationLog(async () => {
   await deployAllMicrosoft();
 }, 'Deploy-all-microsoft');
 
 // Collect Microsoft artifact information (universal + platform-specific VSIXs)
 const microsoftArtifacts = collectArtifactInfo();
 
-// Deploy OpenVSX variants (without OmniSharp in platform-specific packages)
+// Deploy OpenVSX variants
 // This overwrites the platform-specific VSIXs, but we've already captured Microsoft metadata
 await executeWithDurationLog(async () => {
   await deployAllOpenVSX();

build-sonarlint/deployAllOpenVSX.mjs

@@ -23,7 +23,6 @@ export async function deployAllOpenVSX() {
 }
 
 async function buildOpenVSXPackages() {
-  // Build platform-specific packages WITHOUT OmniSharp
   for (const platform of TARGETED_PLATFORMS) {
     await executeWithDurationLog(async () => {
       await downloadJre(platform, LATEST_JRE);

build-sonarlint/fsUtils.mjs

@@ -21,12 +21,6 @@ export function cleanJreDir() {
   }
 }
 
-export function cleanOmnisharpDir() {
-  if (pathExistsSync('./omnisharp')) {
-    removeSync('./omnisharp');
-  }
-}
-
 export function getPackageJSON() {
   return JSON.parse(readFileSync('package.json').toString());
 }

build-sonarlint/omnisharpDownload.mjs

@@ -6,25 +6,16 @@
  * ------------------------------------------------------------------------------------------ */
 'use strict';
 import _default from './constants.mjs'; 
-const { TARGETED_PLATFORMS, LATEST_JRE, OMNISHARP_VERSION } = _default;
+const { TARGETED_PLATFORMS, LATEST_JRE } = _default;
 import downloadJre from './jreDownload.mjs';
-import { cleanJreDir, cleanOmnisharpDir } from './fsUtils.mjs';
+import { cleanJreDir } from './fsUtils.mjs';
 import { createVSIX } from '@vscode/vsce';
-import {
-  downloadAndExtractOmnisharp,
-  downloadOmnisharpAllPlatformDistributions,
-  omnisharpPlatformMapping
-} from './omnisharpDownload.mjs';
 
 (async () => {
   for (const platform of TARGETED_PLATFORMS) {
     await downloadJre(platform, LATEST_JRE);
-    await downloadAndExtractOmnisharp(OMNISHARP_VERSION, omnisharpPlatformMapping[platform]);
-    await downloadAndExtractOmnisharp(OMNISHARP_VERSION, 'net6.0');
     await createVSIX({ target: platform });
-    cleanOmnisharpDir();
   }
   cleanJreDir();
-  await downloadOmnisharpAllPlatformDistributions(OMNISHARP_VERSION);
   await createVSIX();
 })();

build-sonarlint/package-all-microsoft.mjs

@@ -6,18 +6,14 @@
  * ------------------------------------------------------------------------------------------ */
 'use strict';
 import _default from './constants.mjs';
-const { LATEST_JRE, OMNISHARP_VERSION, TARGETED_PLATFORMS } = _default;
+const { LATEST_JRE, TARGETED_PLATFORMS } = _default;
 import downloadJre from './jreDownload.mjs';
 import { cleanJreDir } from './fsUtils.mjs';
 import { createVSIX } from '@vscode/vsce';
-import { downloadOmnisharpAllPlatformDistributions } from './omnisharpDownload.mjs';
 
-// Build platform-specific packages WITHOUT OmniSharp
 for (const platform of TARGETED_PLATFORMS) {
   await downloadJre(platform, LATEST_JRE);
   await createVSIX({ target: platform });
 }
 cleanJreDir();
-// Build universal package WITH OmniSharp
-await downloadOmnisharpAllPlatformDistributions(OMNISHARP_VERSION);
 await createVSIX();

build-sonarlint/package-all-ovsx.mjs

@@ -6,14 +6,7 @@
  * ------------------------------------------------------------------------------------------ */
 'use strict';
 import { createVSIX } from '@vscode/vsce';
-import { downloadOmnisharpAllPlatformDistributions } from './omnisharpDownload.mjs';
-import { cleanOmnisharpDir } from './fsUtils.mjs';
-import _default from './constants.mjs';
-
-const { OMNISHARP_VERSION } = _default;
 
 (async () => {
-  await downloadOmnisharpAllPlatformDistributions(OMNISHARP_VERSION);
   await createVSIX();
-  cleanOmnisharpDir();
 })();

build-sonarlint/package.mjs

@@ -1495,7 +1495,7 @@
     {
       "groupId": "org.sonarsource.sonarlint.ls",
       "artifactId": "sonarlint-language-server",
-      "version": "5.1.0.78319",
+      "version": "5.2.0.78330",
       "output": "server/sonarlint-ls.jar"
     },
     {