fix: action.yml default meta-repo-ref must be floating major tag (#40)

The `meta-repo-ref` default in .github/actions/drift-check/action.yml
was hardcoded to 'v1.7' and never updated when 1.8 and 1.9 shipped.
Tool repos consuming the action without explicit override would get
the meta-repo checked out at v1.7 regardless of which version of the
action they pinned, producing inverse-direction version-signal drift
if their signals ever moved past 1.7.0.

Fixes by changing the default to 'v1' (the auto-maintained MAJOR
floating tag per DTD#14). Future MINORs auto-flow through this
default without requiring action.yml edits.

Surfaced during the v1.7.0 -> v1.9.0 ecosystem signal rollout when
the Home-Lab canary's drift-check failed with 35 inverse-direction
warnings: tool signals at 1.9.0 vs action's hardcoded v1.7
meta-VERSION.

Adds regression test asserting the default matches floating-major
pattern (v[0-9]+) to prevent re-introduction.

Refs TMHSDigital/Home-Lab-Developer-Tools#18.


Made-with: Cursor

Signed-off-by: TMHSDigital <154358121+TMHSDigital@users.noreply.github.com>

Author: TMHSDigital

.github/actions/drift-check/action.yml

@@ -57,9 +57,9 @@ inputs:
     required: false
     default: '3.11'
   meta-repo-ref:
-    description: 'git ref of TMHSDigital/Developer-Tools-Directory to use for the checker code. Defaults to v1.7 (latest 1.7.x).'
+    description: 'git ref of TMHSDigital/Developer-Tools-Directory to use for the checker code. Defaults to v1 (auto-maintained MAJOR floating tag, per DTD#14). Future MINORs auto-flow through this default without requiring action.yml edits.'
     required: false
-    default: 'v1.7'
+    default: 'v1'
   caller-path:
     description: 'When mode=self, path inside GITHUB_WORKSPACE that points at the caller checkout. Defaults to "." (root).'
     required: false

VERSION

@@ -1 +1 @@
-1.9.0
+1.9.1

tests/test_composite_action_shape.py

@@ -142,3 +142,27 @@ def test_action_sticky_step_does_not_swallow_rc(action_doc):
     assert "exit \"$RC\"" not in body and "exit $RC" not in body, (
         "sticky step must not propagate its own RC; that's the propagate step's job"
     )
+
+
+def test_meta_repo_ref_default_is_floating_major(action_doc):
+    """The meta-repo-ref input must default to a floating MAJOR tag
+    (v1, v2, ...), never a specific MINOR (v1.7) or PATCH (v1.7.5).
+
+    Regression guard for the bug surfaced during the v1.9.0 ecosystem
+    signal rollout: the default was hardcoded to 'v1.7' and never bumped
+    when 1.8/1.9 shipped. Tool repos consuming the action without an
+    explicit ``meta-repo-ref`` override silently checked out the meta-repo
+    at v1.7, so any tool signals past 1.7.0 produced inverse-direction
+    version-signal warnings.
+
+    Floating-major is the right granularity because DTD#14 auto-maintains
+    v1 to point at the latest 1.x.y release, so future MINORs auto-flow
+    through this default with zero action.yml edits.
+    """
+    import re
+
+    meta_ref_default = action_doc["inputs"]["meta-repo-ref"]["default"]
+    assert re.match(r"^v\d+$", meta_ref_default), (
+        f"meta-repo-ref default must be a floating major tag (v1, v2, ...) "
+        f"per DTD#14 to avoid stale references; got {meta_ref_default!r}"
+    )