feat(macos): add Swift Package Manager support#21
Open
vitormf wants to merge 3 commits into
Open
Conversation
Dynamic SPM products are transitive deps of the static FlutterGeneratedPluginSwiftPackage and Xcode does not auto-embed them, causing a crash at launch. Declaring type: .static links flutter_pty directly into the app binary with no embedding needed.
…k open
DynamicLibrary.open('flutter_pty.framework/flutter_pty') requires the
framework to be present in the app bundle. With SPM type: .static the
code is linked into the app binary but no .framework is embedded, so
dlopen fails at runtime.
DynamicLibrary.process() resolves symbols from the already-loaded
process image, which works for both SPM (static) and CocoaPods
(framework already mapped before Dart starts).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Flutter 3.22+ detects SPM support in a plugin by looking for
Package.swiftatmacos/<plugin_name>/Package.swift. This PR adds that file so Flutter 3.44+ (which defaults to SPM) no longer warns thatflutter_ptydoesn't support Swift Package Manager for macOS.Changes
macos/flutter_pty/Package.swift— new SPM manifest with a C target;path: "Classes"points to sources inside the package directorymacos/flutter_pty/Classes/— sources moved frommacos/Classes/; C forwarder updated from#include "../../src/flutter_pty.c"to#include "../../../src/flutter_pty.c"to match the new relative locationmacos/flutter_pty.podspec—source_filesupdated fromClasses/**/*toflutter_pty/Classes/**/*so CocoaPods still resolves correctlyCompatibility
Tested across three configurations:
flutter pub getno longer listsflutter_ptyunder "The following plugins do not support Swift Package Manager for macos".Notes
macos/flutter_pty/Classes/up three levels tosrc/