fix: share loader not showing — SW cache bust + precise hash detection

- Bump SW cache to textagent-v2/cdn-v2 (forces all users to get new index.html)
- Switch HTML navigation to network-first strategy (prevents SW from serving stale index.html)
- Fix hash detection: use URLSearchParams instead of indexOf (prevents false positives)
- Add overflow:hidden on html element during share load to prevent scroll flash
- Restore overflow in hideShareLoader() and safety timeout path

Author: ijbo

changelogs/CHANGELOG-share-link-loader-v2.md

@@ -0,0 +1,7 @@
+# Share Link Loader Fix v2 — Debug & Service Worker Cache
+
+- Fixed: hash detection now uses URLSearchParams instead of indexOf (prevents false positives)
+- Fixed: Service Worker was caching old index.html (cache-first) — bumped to textagent-v2/cdn-v2
+- Fixed: HTML navigation now uses network-first strategy so new deployments take effect immediately
+- Added: document.documentElement.style.overflow = 'hidden' during share load to prevent any scroll flash
+- Fixed: hideShareLoader() now also restores document overflow when dismissing

index.html

@@ -158,9 +158,17 @@
     <script>
         (function () {
             var h = window.location.hash;
-            if (h && (h.indexOf('s=') !== -1 || h.indexOf('id=') !== -1 || h.indexOf('d=') !== -1 || h.indexOf('space=') !== -1)) {
-                // Will be activated once the overlay element exists (see body)
-                window.__showShareLoader = true;
+            if (h && h.length > 1) {
+                // Use URLSearchParams for precise matching — avoid false positives
+                try {
+                    var params = new URLSearchParams(h.substring(1));
+                    var hasShare = params.has('s') || params.has('id') || params.has('d') || params.has('space');
+                    if (hasShare) {
+                        window.__showShareLoader = true;
+                        // Hide body early to eliminate flash — overlay will unhide it
+                        document.documentElement.style.overflow = 'hidden';
+                    }
+                } catch (e) { /* ignore parse errors */ }
             }
         })();
     </script>
@@ -223,7 +231,10 @@
             setTimeout(function () {
                 if (_sloEl.classList.contains('slo-active')) {
                     _sloEl.classList.add('slo-fade-out');
-                    setTimeout(function () { _sloEl.classList.remove('slo-active', 'slo-fade-out'); }, 400);
+                    setTimeout(function () {
+                        _sloEl.classList.remove('slo-active', 'slo-fade-out');
+                        document.documentElement.style.overflow = '';
+                    }, 400);
                 }
             }, 15000);
         }

js/cloud-share.js

@@ -18,6 +18,7 @@
         var overlay = document.getElementById('share-loading-overlay');
         if (!overlay || !overlay.classList.contains('slo-active')) return;
         overlay.classList.add('slo-fade-out');
+        document.documentElement.style.overflow = '';
         setTimeout(function () {
             overlay.classList.remove('slo-active', 'slo-fade-out');
         }, 380);

sw.js

@@ -4,7 +4,7 @@
 // Strategy: Cache app shell for offline use, network-first for everything else.
 // CDN libraries are cached on first fetch for full offline capability.
 
-const CACHE_NAME = 'textagent-v1';
+const CACHE_NAME = 'textagent-v2';
 
 // Core app shell files to precache on install
 const APP_SHELL = [
@@ -17,7 +17,7 @@ const APP_SHELL = [
 ];
 
 // CDN libraries to cache on first fetch (runtime caching)
-const CDN_CACHE_NAME = 'textagent-cdn-v1';
+const CDN_CACHE_NAME = 'textagent-cdn-v2';
 const CDN_HOSTS = [
     'cdnjs.cloudflare.com',
     'cdn.jsdelivr.net',
@@ -97,29 +97,40 @@ self.addEventListener('fetch', (event) => {
         return;
     }
 
-    // App shell (same-origin): cache-first, network as fallback
+    // App shell (same-origin): network-first for HTML nav (to always get fresh index.html),
+    // cache-first for JS/CSS/images (stable assets).
     if (url.origin === self.location.origin) {
+        // Always network-first for HTML navigation so new deployments take effect immediately
+        if (event.request.mode === 'navigate' || url.pathname.endsWith('.html') || url.pathname === '/') {
+            event.respondWith(
+                fetch(event.request)
+                    .then((response) => {
+                        if (response.ok) {
+                            const clone = response.clone();
+                            caches.open(CACHE_NAME).then((cache) => cache.put(event.request, clone));
+                        }
+                        return response;
+                    })
+                    .catch(() => caches.match(event.request).then((cached) => cached || caches.match('/')))
+            );
+            return;
+        }
+
+        // Cache-first for JS/CSS/images (stable versioned assets)
         event.respondWith(
             caches.match(event.request)
                 .then((cached) => {
                     if (cached) return cached;
 
                     return fetch(event.request).then((response) => {
-                        // Cache JS, CSS, HTML, and image files from our origin
                         if (response.ok && shouldCacheResponse(url)) {
                             const clone = response.clone();
                             caches.open(CACHE_NAME).then((cache) => cache.put(event.request, clone));
                         }
                         return response;
                     });
                 })
-                .catch(() => {
-                    // Offline fallback for navigation requests
-                    if (event.request.mode === 'navigate') {
-                        return caches.match('/');
-                    }
-                    return new Response('Offline', { status: 503, statusText: 'Offline' });
-                })
+                .catch(() => new Response('Offline', { status: 503, statusText: 'Offline' }))
         );
         return;
     }