refactor(string): Change Unicode_To_Utf8 and Utf8_To_Unicode to return bool on failure

Author: bobtista

Core/GameEngine/Source/Common/System/AsciiString.cpp

@@ -280,7 +280,8 @@ void AsciiString::translate(const UnicodeString& stringSrc)
 	if (size == 0)
 		return;
 	char* buf = getBufferForRead((Int)size);
-	Unicode_To_Utf8(buf, src, size + 1);
+	if (!Unicode_To_Utf8(buf, src, size + 1))
+		clear();
 	validate();
 }
 

Core/GameEngine/Source/Common/System/UnicodeString.cpp

@@ -229,7 +229,8 @@ void UnicodeString::translate(const AsciiString& stringSrc)
 	if (size == 0)
 		return;
 	WideChar* buf = getBufferForRead((Int)size);
-	Utf8_To_Unicode(buf, src, size + 1);
+	if (!Utf8_To_Unicode(buf, src, size + 1))
+		clear();
 	validate();
 }
 

Core/Libraries/Source/WWVegas/WWLib/utf8.cpp

@@ -96,22 +96,24 @@ size_t Get_Unicode_Size(const char* src)
 	return (wchars > 1) ? (size_t)(wchars - 1) : 0;
 }
 
-void Unicode_To_Utf8(char* dest, const wchar_t* src, size_t dest_size)
+bool Unicode_To_Utf8(char* dest, const wchar_t* src, size_t dest_size)
 {
 	if (dest_size == 0)
-		return;
+		return false;
 	int result = WideCharToMultiByte(CP_UTF8, 0, src, -1, dest, (int)dest_size, nullptr, nullptr);
 	if (result == 0)
 		dest[0] = '\0';
+	return result != 0;
 }
 
-void Utf8_To_Unicode(wchar_t* dest, const char* src, size_t dest_size)
+bool Utf8_To_Unicode(wchar_t* dest, const char* src, size_t dest_size)
 {
 	if (dest_size == 0)
-		return;
+		return false;
 	int result = MultiByteToWideChar(CP_UTF8, 0, src, -1, dest, (int)dest_size);
 	if (result == 0)
 		dest[0] = L'\0';
+	return result != 0;
 }
 
 #else

Core/Libraries/Source/WWVegas/WWLib/utf8.h

@@ -42,7 +42,9 @@ size_t Get_Utf8_Size(const wchar_t* src);
 size_t Get_Unicode_Size(const char* src);
 
 // Converts a wide character string to UTF-8. dest_size is in bytes.
-void Unicode_To_Utf8(char* dest, const wchar_t* src, size_t dest_size);
+// Returns true on success, false on failure. On failure, dest[0] is set to '\0'.
+bool Unicode_To_Utf8(char* dest, const wchar_t* src, size_t dest_size);
 
 // Converts a UTF-8 string to wide characters. dest_size is in wchar_t elements.
-void Utf8_To_Unicode(wchar_t* dest, const char* src, size_t dest_size);
+// Returns true on success, false on failure. On failure, dest[0] is set to L'\0'.
+bool Utf8_To_Unicode(wchar_t* dest, const char* src, size_t dest_size);