From 2701dd0f8b21a159eaf2856001c8bf0af73b0873 Mon Sep 17 00:00:00 2001 From: "deepsource-autofix[bot]" <62050782+deepsource-autofix[bot]@users.noreply.github.com> Date: Sat, 20 Sep 2025 20:07:59 +0000 Subject: [PATCH] refactor: use char overload for StringBuilder.Append This PR replaces instances of StringBuilder.Append(string) when appending single characters with the more efficient Append(char) overload. By using char literals instead of one-character strings, we reduce unnecessary string allocations and improve performance. - Consider using more appropriate overload `StringBuilder.Append(char)`: In multiple spots the code was calling `Append(" ")` or `Append("&")`, which allocates a new string for each call. These have been replaced with `Append(' ')` and `Append('&')` respectively to leverage the `Append(char)` overload and cut down on memory usage. > This Autofix was generated by AI. Please review the change before merging. --- Shared/Middleware/RequestLoggingMiddleware.cs | 2 +- Shared/Middleware/ResponseLoggingMiddleware.cs | 2 +- Shared/Web/QueryStringBuilder.cs | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/Shared/Middleware/RequestLoggingMiddleware.cs b/Shared/Middleware/RequestLoggingMiddleware.cs index 1aad3030..bd37173c 100644 --- a/Shared/Middleware/RequestLoggingMiddleware.cs +++ b/Shared/Middleware/RequestLoggingMiddleware.cs @@ -43,7 +43,7 @@ public async Task Invoke(HttpContext context, RequestResponseMiddlewareLoggingCo logMessage.Append($"Request: Method: {context.Request.Method} Url: {url}"); if (requestBodyText != String.Empty) { - logMessage.Append(" "); + logMessage.Append(' '); logMessage.Append($"Body: {requestBodyText}"); } diff --git a/Shared/Middleware/ResponseLoggingMiddleware.cs b/Shared/Middleware/ResponseLoggingMiddleware.cs index bd9012b3..e15efcb9 100644 --- a/Shared/Middleware/ResponseLoggingMiddleware.cs +++ b/Shared/Middleware/ResponseLoggingMiddleware.cs @@ -50,7 +50,7 @@ public async Task Invoke(HttpContext context, RequestResponseMiddlewareLoggingCo logMessage.Append($"Response: Status Code: {context.Response.StatusCode}"); if (!String.IsNullOrEmpty(responseBody)) { - logMessage.Append(" "); + logMessage.Append(' '); logMessage.Append($"Body: {responseBody}"); } diff --git a/Shared/Web/QueryStringBuilder.cs b/Shared/Web/QueryStringBuilder.cs index 3404dfb9..d14dce51 100644 --- a/Shared/Web/QueryStringBuilder.cs +++ b/Shared/Web/QueryStringBuilder.cs @@ -75,7 +75,7 @@ public string BuildQueryString() { if (queryString.Length > 0) { - queryString.Append("&"); + queryString.Append('&'); } queryString.Append($"{Uri.EscapeDataString(kvp.Key)}={Uri.EscapeDataString(kvp.Value.ToString())}");