fix(test): make TAP exit-code assertion strict-mode safe

Chemaclass · Chemaclass · commit 99f4a07d05fd · 2026-04-18T14:49:26.000+02:00
diff --git a/tests/acceptance/bashunit_tap_output_test.sh b/tests/acceptance/bashunit_tap_output_test.sh
@@ -31,6 +31,5 @@ function test_tap_output_env_var_equivalent_to_flag() {
 function test_tap_output_exits_non_zero_on_failure() {
   local test_file=tests/acceptance/fixtures/test_bashunit_when_a_test_fail.sh
 
-  ./bashunit --no-parallel --env "$TEST_ENV_FILE" --output tap "$test_file" >/dev/null 2>&1
-  assert_general_error "$?"
+  assert_general_error "$(./bashunit --no-parallel --env "$TEST_ENV_FILE" --output tap "$test_file" 2>&1)"
 }

Original file line number	Diff line number	Diff line change
`@@ -31,6 +31,5 @@ function test_tap_output_env_var_equivalent_to_flag() {`
`31`	`31`	`function test_tap_output_exits_non_zero_on_failure() {`
`32`	`32`	`local test_file=tests/acceptance/fixtures/test_bashunit_when_a_test_fail.sh`
`33`	`33`
`34`		`- ./bashunit --no-parallel --env "$TEST_ENV_FILE" --output tap "$test_file" >/dev/null 2>&1`
`35`		`- assert_general_error "$?"`
	`34`	`+ assert_general_error "$(./bashunit --no-parallel --env "$TEST_ENV_FILE" --output tap "$test_file" 2>&1)"`
`36`	`35`	`}`