Merge pull request #133 from USACE-RMC/bugfixes-and-enhancements

v2.0.0: Bugfixes, enhancements, and JOSS paper

Author: HadenSmith

.github/release.yml

@@ -0,0 +1,10 @@
+changelog:
+  categories:
+    - title: New Features
+      labels: [enhancement, feature]
+    - title: Bug Fixes
+      labels: [bug, fix]
+    - title: Documentation
+      labels: [documentation]
+    - title: Other Changes
+      labels: ["*"]

.github/workflows/Integration.yml

@@ -8,5 +8,5 @@ jobs:
   CI:
     uses: HydrologicEngineeringCenter/dotnet-workflows/.github/workflows/integration.yml@main
     with:
-      dotnet-version: '9.0.x'
+      dotnet-version: '10.0.x'
       run-tests: true

.github/workflows/NuGetPublish.yml

@@ -0,0 +1,37 @@
+name: Publish to NuGet.org
+
+on:
+  release:
+    types: [published]
+
+jobs:
+  publish:
+    runs-on: windows-latest
+    steps:
+      - uses: actions/checkout@v4
+        with:
+          fetch-depth: 0
+
+      - uses: actions/setup-dotnet@v4
+        with:
+          dotnet-version: |
+            8.0.x
+            9.0.x
+            10.0.x
+
+      - name: Extract version from tag
+        id: version
+        shell: bash
+        run: echo "VERSION=${GITHUB_REF_NAME#v}" >> $GITHUB_OUTPUT
+
+      - name: Build
+        run: dotnet build Numerics/Numerics.csproj -c Release -p:Version=${{ steps.version.outputs.VERSION }}
+
+      - name: Test (all frameworks)
+        run: dotnet test -c Release --no-build
+
+      - name: Pack
+        run: dotnet pack Numerics/Numerics.csproj -c Release --no-build -p:Version=${{ steps.version.outputs.VERSION }}
+
+      - name: Push to NuGet.org
+        run: dotnet nuget push "Numerics/bin/Release/RMC.Numerics.${{ steps.version.outputs.VERSION }}.nupkg" --api-key ${{ secrets.NUGET_ORG_API_KEY }} --source https://api.nuget.org/v3/index.json --skip-duplicate

.gitignore

@@ -370,3 +370,4 @@ MigrationBackup/
 
 #Numerics Specific
 /TestResults
+/.claude/settings.local.json

CITATION.cff

@@ -0,0 +1,45 @@
+cff-version: 1.2.0
+message: "If you use this software, please cite it as below."
+type: software
+title: "Numerics"
+version: "2.0.0"
+date-released: "2026-03-08"
+license: BSD-3-Clause
+repository-code: "https://github.com/USACE-RMC/Numerics"
+url: "https://github.com/USACE-RMC/Numerics"
+abstract: >-
+  Numerics is a free and open-source .NET library providing numerical methods,
+  probability distributions, statistical analysis, and Bayesian inference tools
+  for quantitative risk assessment in water resources engineering.
+keywords:
+  - statistics
+  - probability distributions
+  - MCMC
+  - hydrology
+  - flood frequency analysis
+  - copulas
+  - L-moments
+  - optimization
+  - .NET
+  - C#
+authors:
+  - family-names: "Smith"
+    given-names: "C. Haden"
+    email: "cole.h.smith@usace.army.mil"
+    affiliation: "U.S. Army Corps of Engineers, Risk Management Center"
+    orcid: "https://orcid.org/0000-0002-4651-9890"
+  - family-names: "Fields"
+    given-names: "Woodrow L."
+    affiliation: "U.S. Army Corps of Engineers, Risk Management Center"
+  - family-names: "Gonzalez"
+    given-names: "Julian"
+    affiliation: "U.S. Army Corps of Engineers, Risk Management Center"
+  - family-names: "Niblett"
+    given-names: "Sadie"
+    affiliation: "U.S. Army Corps of Engineers, Risk Management Center"
+  - family-names: "Beam"
+    given-names: "Brennan"
+    affiliation: "U.S. Army Corps of Engineers, Hydrologic Engineering Center"
+  - family-names: "Skahill"
+    given-names: "Brian"
+    affiliation: "Fariborz Maseeh Department of Mathematics and Statistics, Portland State University"

CODE_OF_CONDUCT.md

@@ -0,0 +1,13 @@
+# Code of Conduct
+
+This project follows the [Contributor Covenant Code of Conduct v2.1](https://www.contributor-covenant.org/version/2/1/code_of_conduct/).
+
+Please read the full text at the link above. In summary, we are committed to providing a welcoming and inclusive environment for everyone. Be respectful, constructive, and professional in all interactions.
+
+## Reporting
+
+If you experience or witness unacceptable behavior, please contact the project maintainers at cole.h.smith@usace.army.mil.
+
+## Attribution
+
+This Code of Conduct is adapted from the [Contributor Covenant](https://www.contributor-covenant.org), version 2.1.

CONTRIBUTING.md

@@ -0,0 +1,63 @@
+# Contributing to Numerics
+
+Thank you for your interest in contributing to Numerics! We welcome bug reports, feature requests, validation results, and other feedback from the community.
+
+## Review Capacity
+
+Numerics is maintained by a small team within the U.S. Army Corps of Engineers Risk Management Center (USACE-RMC). **Our capacity to review external pull requests is very limited.** We prioritize issues and bug reports, which are always welcome and will be reviewed as resources permit.
+
+If you plan to submit a pull request, please open an issue first to discuss your proposed change. This helps avoid duplicated effort and ensures your contribution aligns with the project's direction.
+
+## How to Contribute
+
+### Report a Bug
+
+If you find a bug, please [open an issue](../../issues/new) and include:
+
+- Steps to reproduce the problem
+- Input data and configuration (if applicable)
+- Expected behavior vs. actual behavior
+- Software version and operating system
+- Any relevant error messages or screenshots
+
+### Request a Feature
+
+Feature requests are welcome. Please [open an issue](../../issues/new) describing:
+
+- The use case or problem you are trying to solve
+- How you envision the feature working
+- Any references to statistical methods or published literature
+
+### Report Validation Results
+
+Given the life-safety applications of this software, independent validation is especially valuable. If you have compared Numerics results against other software (e.g., R packages, published tables, or analytical solutions), we would appreciate hearing about it through an issue.
+
+### Submit a Pull Request
+
+Pull requests may take several weeks or longer to review. Before submitting code:
+
+1. **Open an issue first** to discuss the proposed change
+2. **Follow the coding standards**, including XML documentation on all public types and members
+3. **Include unit tests** that validate against known results (R, SciPy, Mathematica, or published tables)
+4. **Use MSTest** (`[TestClass]`, `[TestMethod]`) as the testing framework
+5. **Ensure a clean build** with zero errors and zero warnings
+
+## Developer Certificate of Origin
+
+By submitting a pull request, you certify under the [Developer Certificate of Origin (DCO) Version 1.1](https://developercertificate.org/) that you have the right to submit the work under the license associated with this project and that you agree to the DCO.
+
+All contributions will be released under the same license as the project (see [LICENSE](LICENSE)).
+
+## Federal Government Contributors
+
+U.S. Federal law prevents the government from accepting gratuitous services unless certain conditions are met. By submitting a pull request, you acknowledge that your services are offered without expectation of payment and that you expressly waive any future pay claims against the U.S. Federal government related to your contribution.
+
+If you are a U.S. Federal government employee and use a `*.mil` or `*.gov` email address, your contribution is understood to have been created in whole or in part as part of your official duties and is not subject to domestic copyright protection under 17 USC 105.
+
+## Security
+
+If you discover a security vulnerability, please do **not** open a public issue. Instead, contact the RMC team directly through official USACE-RMC channels.
+
+## License
+
+See [LICENSE](LICENSE) for details. This software is provided by USACE-RMC under a BSD-style license with a no-endorsement clause.

Numerics.sln

@@ -1,7 +1,7 @@
 
 Microsoft Visual Studio Solution File, Format Version 12.00
-# Visual Studio Version 17
-VisualStudioVersion = 17.9.34723.18
+# Visual Studio Version 18
+VisualStudioVersion = 18.2.11430.68 d18.0
 MinimumVisualStudioVersion = 10.0.40219.1
 Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "Numerics", "Numerics\Numerics.csproj", "{9C8B75DE-ABF2-42D3-96C7-18405AD16488}"
 EndProject

Numerics/Data/Interpolation/Bilinear.cs

@@ -119,7 +119,7 @@ public bool UseSmartSearch
             {
                 _useSmartSearch = value;
                 X1LI.UseSmartSearch = value;
-                X1LI.UseSmartSearch = value;
+                X2LI.UseSmartSearch = value;
             }
         }
 

Numerics/Data/Interpolation/CubicSpline.cs

@@ -28,6 +28,9 @@
 * THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 */
 
+using System;
+using System.Collections.Generic;
+
 namespace Numerics.Data
 {
     /// <summary>
@@ -62,7 +65,7 @@ public class CubicSpline : Interpolater
     {
 
         /// <summary>
-        /// Construct new linear interpolation. 
+        /// Construct new cubic spline interpolation.
         /// </summary>
         /// <param name="xValues">List of x-values.</param>
         /// <param name="yValues">List of y-values.</param>
@@ -75,7 +78,7 @@ public CubicSpline(IList<double> xValues, IList<double> yValues, SortOrder sortO
         /// <summary>
         /// Stores the array of second derivatives.
         /// </summary>
-        private double[] y2 = Array.Empty<double>();
+        private double[] y2 = null!;
 
         /// <summary>
         /// Auxiliary routine to set the second derivatives. If you make changes to the x- or y-values, then you need to call this routine afterwards.